Fix RRULE evaluation for recurring CPC working session events#1737
Merged
bensternthal merged 1 commit intoopenjs-foundation:mainfrom Feb 10, 2026
Merged
Conversation
The awk script was matching the literal target date against DTSTART, but recurring iCal events only store the series start date in DTSTART. Individual occurrences must be computed from the RRULE. This change: - Extracts all CPC working session events without date filtering - Evaluates RRULE (INTERVAL, BYDAY) to compute if today is a valid occurrence - Checks EXDATE entries to skip cancelled occurrences - Falls back to direct DTSTART matching for single (non-recurring) events
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The GitHub Action for creating CPC working session agendas was not detecting meetings. It ran on 2026-02-10 and reported "No CPC working session found" even though one was on the calendar.
Root Cause
The
awkscript was doing simple text matching, looking for the literal target date in theDTSTARTfield:But recurring iCal events only store the series start date in
DTSTART(e.g.,20241022), not each individual occurrence. The actual occurrences are computed fromDTSTART+RRULE. So the script would never match any date other than the original series start date.Fix
Replace the naive text matching with proper RRULE evaluation:
RRULEto determine if today is a valid occurrence:BYDAYmatches today's day of the weekDTSTARTand check divisibility byINTERVALEXDATEentries to skip cancelled occurrencesDTSTARTmatching for single (non-recurring) eventsTested against multiple dates including meeting days, off-weeks, excluded dates, and wrong days of the week.