Merged
Conversation
Closed
There was a problem hiding this comment.
Pull Request Overview
This pull request updates the NEWS.md file to document the new release of ojothemes 1.1.0.
- Adds release notes with the new version and date
- Mentions an update to gt_* functions regarding Title Case formatting using
{snakecase}
Files not reviewed (3)
- DESCRIPTION: Language not supported
- R/ojo_gt.R: Language not supported
- ojothemes.Rproj: Language not supported
Comments suppressed due to low confidence (1)
NEWS.md:3
- [nitpick] There's a potential ambiguity between 'Title Case' and the use of
{snakecase}in the description. Please clarify whether the update involves converting table headers to Title Case or applying snake case transformation to the gt_* functions.
* Brings clean "Title Case" to gt_* functions using `{snakecase}`
There was a problem hiding this comment.
Pull Request Overview
This pull request updates the NEWS.md file to announce version 1.1.0 of ojothemes, highlighting a new feature for pretty table headers.
- Updated the release notes to mention the implementation of clean "Title Case" for column headers.
- Noted the use of
{snakecase}in the header generation process.
Files not reviewed (3)
- DESCRIPTION: Language not supported
- R/ojo_gt.R: Language not supported
- ojothemes.Rproj: Language not supported
Comments suppressed due to low confidence (1)
NEWS.md:3
- [nitpick] The release note description is a bit ambiguous since it mentions both 'Title Case' and the usage of
{snakecase}. Consider clarifying whether{snakecase}is used for formatting or if a separate mechanism applies to produce Title Case headers.
* Brings clean "Title Case" to column headers created by gt_* functions using `{snakecase}`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.