Skip to content

Conversation

@auloin
Copy link
Contributor

@auloin auloin commented Apr 30, 2019

No description provided.

@auloin auloin changed the base branch from feature/expenses-frontend to feature/expenses-backend April 30, 2019 10:41
@auloin auloin changed the base branch from feature/expenses-backend to feature/expenses-frontend April 30, 2019 10:41
@auloin auloin changed the title Feature/invoices backend Backend: invoice upload May 3, 2019
@auloin auloin marked this pull request as ready for review May 3, 2019 09:22
@auloin auloin changed the base branch from feature/expenses-frontend to develop May 3, 2019 09:28
Copy link
Contributor

@archived-m archived-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mint.

Nice tests 🔥

}
invoice.category = category;
}
invoice.flow = 'IN';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe these should be constants declared in a constants file

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't think about it, yeah it'd better that way.

@auloin auloin requested a review from archived-m May 13, 2019 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants