[Feature] support custom e2b #34
Conversation
AiRanthem
changed the title
AiRanthem
changed the title
kruise-bot
added
needs-rebase
size/XXL
and removed
do-not-merge/work-in-progress
size/XL
labels
Signed-off-by: AiRanthem <zhongtianyun.zty@alibaba-inc.com>
Signed-off-by: AiRanthem <zhongtianyun.zty@alibaba-inc.com>
Signed-off-by: AiRanthem <zhongtianyun.zty@alibaba-inc.com>
Signed-off-by: AiRanthem <zhongtianyun.zty@alibaba-inc.com>
Signed-off-by: AiRanthem <zhongtianyun.zty@alibaba-inc.com>
Signed-off-by: AiRanthem <zhongtianyun.zty@alibaba-inc.com>
Signed-off-by: AiRanthem <zhongtianyun.zty@alibaba-inc.com>
Signed-off-by: AiRanthem <zhongtianyun.zty@alibaba-inc.com>
AiRanthem
force-pushed
the
feature/custom-e2b-protocol-251219
branch
from
274c41b to
13d8a9b
Compare
Signed-off-by: AiRanthem <zhongtianyun.zty@alibaba-inc.com>
Signed-off-by: AiRanthem <zhongtianyun.zty@alibaba-inc.com>
| } | ||
| handleFunc := func(w http.ResponseWriter, r *http.Request) { | ||
| written := false | ||
| safeWriteJson := func(ctx context.Context, w http.ResponseWriter, code, defaultCode int, body any, requestID string) { |
There was a problem hiding this comment.
consider rename safeWriteJson to writeJsonOnce
| @@ -0,0 +1,91 @@ | |||
| # Customized E2B SDK patch | |||
There was a problem hiding this comment.
plz rename the file to README-zh_CN.md
|
|
||
| In our practice, we found that in K8s scenarios, this protocol has the following issues: | ||
|
|
||
| 1. Requires configuring wildcard domain resolution to the management service (sandbox-manager), unable to use methods |
There was a problem hiding this comment.
unable to use methods like hosts for resolution ->
unable to use host file for resolution.
| 2. Requires using expensive wildcard certificates. | ||
|
|
||
| The above issues simultaneously make deploying a backend service compatible with E2B have a high threshold: not only | ||
| increasing user costs, but also making it difficult to automate the setup of an E2E test environment. |
There was a problem hiding this comment.
plz revise the text as follows:
The issues above collectively raise the barrier to deploying a backend service compatible with E2B—not only increasing user costs but also complicating the automation of end-to-end (E2E) test environment setup.
|
|
||
| ### 1. Integration using native protocol | ||
|
|
||
| > This is the most standard, native integration method, but also has the highest configuration threshold, generally |
There was a problem hiding this comment.
This is the most standard but also the most complex method
|
|
||
| ### 2. Private protocol HTTPS access from outside cluster | ||
|
|
||
| > This approach can reduce deployment threshold and can be semi-automatically deployed in combination with components |
There was a problem hiding this comment.
revise the text as follows：
This approach lowers the deployment barrier and enables semi-automated deployment when used in conjunction with components such as cert-manager.
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: zmberg The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
4 participants
Ⅰ. Describe what this PR does
see sdk/customized_e2b
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews