add agents-sandbox-controller/manager chart#168
add agents-sandbox-controller/manager chart#168ZhaoQing7892 wants to merge 1 commit intoopenkruise:masterfrom
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Welcome @ZhaoQing7892! It looks like this is your first PR to openkruise/charts 🎉 |
|
|
||
| | 参数 | 描述 | 默认值 | | ||
| |-----------------------------------------------------|--------------------------------------------------------------------|-------------------------------------------------------------------------------------------------| | ||
| | `sandboxController.replicaCount` | sandbox-controller 部署的副本数 | `3` | |
There was a problem hiding this comment.
consider change default replica counts to 2
| @@ -0,0 +1,699 @@ | |||
| {{- if .Values.crds.enabled }} | |||
There was a problem hiding this comment.
consider put crd into separate crd directory
|
|
||
| ## 配置参数 | ||
|
|
||
| 下表列出了 agents-sandbox-controller chart 的可配置参数及其默认值。 |
There was a problem hiding this comment.
plz use English only in README.md, we can add README-zh_CN.md for the Chinese version
| capabilities: | ||
| drop: | ||
| - ALL | ||
| readOnlyRootFilesystem: false |
There was a problem hiding this comment.
can we enable readOnlyRootFilesystem?
| allowPrivilegeEscalation: false | ||
| capabilities: | ||
| drop: | ||
| - ALL |
There was a problem hiding this comment.
shall we keep NET_BIND_SERVICE, otherwise controller cannot serve metrics endpoints
| securityContext: | ||
| capabilities: | ||
| drop: | ||
| - ALL |
There was a problem hiding this comment.
sandbox manager need NET_BIND_SERVICE cap
3 participants
No description provided.