Skip to content

Support kubectl‑kruise top cloneset#132

Open
GautamBytes wants to merge 2 commits intoopenkruise:masterfrom
GautamBytes:add-top-cloneset
Open

Support kubectl‑kruise top cloneset#132
GautamBytes wants to merge 2 commits intoopenkruise:masterfrom
GautamBytes:add-top-cloneset

Conversation

@GautamBytes
Copy link
Copy Markdown
Contributor

This PR introduces the top cloneset command to kubectl‑kruise, allowing users to view aggregated CPU and memory usage for a CloneSet.

  • Adds pkg/top/aggregator.go with pod‑metrics summation logic.
  • Implements pkg/cmd/top/cloneset.go and updates pkg/cmd/top/top.go to register the new subcommand.
  • Extends util.Factory interface for MetricsClient support.

Fixes #8

Signed-off-by: GautamBytes <manchandanigautam@gmail.com>
Signed-off-by: GautamBytes <manchandanigautam@gmail.com>
@kruise-bot kruise-bot requested review from FillZpp and furykerry July 1, 2025 11:34
@kruise-bot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign fillzpp for approval by writing /assign @fillzpp in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@GautamBytes
Copy link
Copy Markdown
Contributor Author

@furykerry , I will raise a diff pr for other remaining 4 workloads soon . You can check this one and tell if improvements are needed. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support kubectl-kruise top cloneset

2 participants