Add unit tests for attachablePodForObject function#139
Open
GautamBytes wants to merge 1 commit intoopenkruise:masterfrom
Open
Add unit tests for attachablePodForObject function#139GautamBytes wants to merge 1 commit intoopenkruise:masterfrom
GautamBytes wants to merge 1 commit intoopenkruise:masterfrom
Conversation
Signed-off-by: GautamBytes <manchandanigautam@gmail.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Contributor
Author
|
@furykerry @FillZpp just pinging for review. Thanks! |
Contributor
Author
@furykerry PTAL! |
Contributor
Author
|
@furykerry @hantmac will you merge these test pr's please! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added unit test for
pkg/internal/polymorphichelpers/attachablepodforobject.go.Our tests successfully validated all the logic paths that don't require a live Kubernetes connection:
The uncovered code is the final "success path" where the function tries to:
This part of the code is not covered because a simple unit test cannot create a real Kubernetes client and connect to the API.