Skip to content

Add unit tests for getViewer function#141

Open
GautamBytes wants to merge 1 commit intoopenkruise:masterfrom
GautamBytes:test/getviewer-unit
Open

Add unit tests for getViewer function#141
GautamBytes wants to merge 1 commit intoopenkruise:masterfrom
GautamBytes:test/getviewer-unit

Conversation

@GautamBytes
Copy link
Copy Markdown
Contributor

What this PR does / why we need it:

This PR introduces comprehensive unit tests for the getViewer function in the polymorphichelpers package. The tests ensure that the function correctly returns a TablePrinter for all supported Kruise resource types and returns the expected error for unsupported types.

Signed-off-by: GautamBytes <manchandanigautam@gmail.com>
@kruise-bot kruise-bot requested review from furykerry and hantmac July 11, 2025 16:23
@kruise-bot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign hantmac for approval by writing /assign @hantmac in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@GautamBytes
Copy link
Copy Markdown
Contributor Author

@hantmac please take a look at this pr and other test prs whenever feasible!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants