Add unit tests for rollout_utils#145
Open
GautamBytes wants to merge 1 commit intoopenkruise:masterfrom
Open
Conversation
Signed-off-by: GautamBytes <manchandanigautam@gmail.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
This PR adds a full unit test suite for
rollout_utils.goto cover its critical helper functions. These functions, which handle pod filtering and partition calculations for CloneSet rollouts, previously had no test coverage, posing a risk for regressions.The new tests use a mock Kubernetes client to ensure all logic can be verified reliably in an isolated environment. This improves the overall stability and code quality of the package.
How to test this PR
This PR consists of a new test file. The changes can be verified by running the test suite for the package and confirming that it passes:
go test ./pkg/internal/polymorphichelpers