Added unit tests for resourcedistribution#150
Open
GautamBytes wants to merge 2 commits intoopenkruise:masterfrom
Open
Added unit tests for resourcedistribution#150GautamBytes wants to merge 2 commits intoopenkruise:masterfrom
GautamBytes wants to merge 2 commits intoopenkruise:masterfrom
Conversation
Signed-off-by: GautamBytes <manchandanigautam@gmail.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Signed-off-by: GautamBytes <manchandanigautam@gmail.com>
Contributor
Author
|
@furykerry please take a look! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's in this PR?
This pull request introduces a robust and comprehensive unit test suite for the
ResourceDistributiongenerator. The primary goal is to validate the generator's behavior across its full feature set, ensuring its output is correct and its error handling is reliable.Key Contributions
Expanded Test Coverage: Adds tests for core features that were previously untested, including:
literalSources.resourceOptions(labels, annotations) to the inner resource.matchExpressionsandexcludedNamespaces.Robust Assertions: The test validation logic has been refactored to unmarshal the expected and actual YAML into
unstructured.Unstructuredobjects. These objects are then compared directly, making the tests more reliable and independent of formatting or key order.