fix: subagent TTL lower bound + robust loopback check#357
Merged
Conversation
1. subagent_tool.py: Add lower bound to TTL clamping (max(1, ...)). Zero or negative ttl_seconds caused immediate asyncio.wait_for timeout, wasting resources spawning a subagent that never runs. 2. server.py: Replace string-based localhost check with ipaddress.ip_address().is_loopback. Handles IPv4-mapped IPv6 addresses (::ffff:127.0.0.1) and removes misleading "localhost" string that Starlette never returns.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two small hardening fixes from principal engineer review:
subagent_tool.py: Add
max(1, ...)lower bound to TTL clamping. Zero or negativettl_secondscausedasyncio.wait_forto time out immediately, wasting resources on a subagent that never runs.server.py: Replace string-based localhost check (
"127.0.0.1", "::1", "localhost") withipaddress.ip_address().is_loopback. This correctly handles IPv4-mapped IPv6 addresses (::ffff:127.0.0.1) and removes the misleading"localhost"string (Starlette always returns numeric IPs, never hostnames).Test plan
pytest tests/ --ignore=tests/test_dashboard.py— 1595 passed, 45 skipped