[hyrrokkin] Don't fail if publicsuffix.org is down.#4
Open
toddthomas wants to merge 1 commit intomaster_1xfrom
Open
[hyrrokkin] Don't fail if publicsuffix.org is down.#4toddthomas wants to merge 1 commit intomaster_1xfrom
toddthomas wants to merge 1 commit intomaster_1xfrom
Conversation
The suffix list is redownloaded from publicsuffix.org every week to keep it up-to-date, but if that download failed in any way, an empty list was written to disk and then used subsequently, resulting in failures to identify any domains. Now, there is a version of the list supplied with the gem. That version is used initially and will be updated on a weekly basis thereafter.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The suffix list is redownloaded from publicsuffix.org every week to keep
it up-to-date, but if that download failed in any way, an empty list was
written to disk and then used subsequently, resulting in failures to
identify any domains.
Now, there is a version of the list supplied with the gem. That version
is used initially and will be updated on a weekly basis thereafter.