-
Notifications
You must be signed in to change notification settings - Fork 596
Gamma contact dose rate computation fispact style #3700
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Gamma contact dose rate computation fispact style #3700
Conversation
Inclusion of the mass energy attenuation and mass energy-absorption coefficients for tabulated photon energies for various material compounds. The database includes material from the Table 4 of the NIST database 126 (https://dx.doi.org/10.18434/T4D01F). Currently only the materials (water, liquid) and (air, dry) is implemented. This data has been included as it is required for Contact Dose Rates computations
This reverts commit 0617952.
GuySten
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general this is a nice feature but you should clean this PR.
There is alot of unnecessary code so this PR should be cleaned up significantly.
I suggest you remove all pieces of code that are not related to the calculation of contact dose rate.
fix data import fix data import 2 fix data import 3
|
@GuySten thanks for the comments! I implemented the suggestions. I hope to get further comments/feedback on the CDR integration when Tabular radiation sources are involved and on how to proceed for the missing relevant features (approximate spectra when no source is present and bremsstrahlung correction). |
|
Currently the tests do not pass. |
|
Replacing the air-absorbed dose with a specified one chosen from the dose conversion factors library, as it was made in #3647, could make this PR compatible with the Monte Carlo part of OpenMC and avoid the air constants usage. Also, it could provide the ability for some inter-dose comparisons, although for gamma only. Of course, that all is not actual if the purpose of this PR is exactly calculation of the absorbed gamma dose in air near an semi-infinite source slab. Append. I meant replacing the term |
|
I liked @vitmog suggestion. @marco-de-pietri, what do you think? |
|
Thank you for the correction, @GuySten: it is computed now kerma, but not absorbed dose as I wrote. |
|
As it is, the method computes the absorbed dose in air as it multiplies the energy fluence with the mass energy-absorption coefficient. To compute the kerma, the energy fluence should multiply the mass energy-transfer coefficient: (g is the fraction of the secondaries kinetic energy lost in radiative processes). Therefore absorbed dose is correct. In the fispact manual the units are Sv but as it is in air it should make sense to specify that the method returns Gy I think. With respect to the modifcation suggestions:
Let me know what your thoughts are |
|
@marco-de-pietri, thank you. You implemented the air mass energy-absorption coefficient, so the dose is absorbed. To compute kerma, we should divide it on About the point source. The both features are different, in my opinion, so I am agreed with @marco-de-pietri. Also, I cannot imagine any real demand for gamma-constant calculation from an user of a code like OpenMC. At the more so, they are always known for bare laboratory sources from its documentation or can be just taken from handbooks while gamma-sources of such the kind does not contain lots of emitting nuclides. In contrast, the feature of this PR can be used for characterization of dose rates near an irradiated sample or spent fuel in some assumptions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to replace the air dose response with one of the standard dose responses in openmc.data.dose_coefficients to make this feature useful to general audience.
Description
Hello everyone, inspired by the discussion related to PR #3647 and the issue #3650, and as I think it is a major feature that could benefit openMC I tried to take a stab in implementing the gamma contact dose rate in the python API.
It is computed following the FISPACT-II methodology (see FISPACT manual appendix C.7.1 https://fispact.ukaea.uk/wp-content/uploads/2021/05/user_manual.pdf ).
In some way the implementation improves over that, as it is not constrained by the 22 energy groups of fispact. Instead, it sums the discrete contributions when the nuclide photon source is of the Discrete type and for Tabular sources it integrates their contribution.
To implement this feature It required the inclusion of methods for computing the material photon attenuation for discrete and tabular energy distributions and the tabulated data set of the photon mass-energy absorption factors in air. A set of test is included for most of the machinery required for the gamma contact dose rate method.
Some additional minor contributions to the gamma contact dose rates are not implemented as some underlying methods required to compute that are still missing. In particular:
computation of approximate gamma spectra for unstable nuclides with no photon source in the chain file: This could be implemented like in fispact if in chain file included the average energy of all light particles, and average energy of all electromagnetic radiation. This info is readily available in the ENDF file i believe?
computation of bremsstrahlung correction. This could be implemented if the python api included the analogous of data.decay_photon_energy for electron and positron source particle in the chain files.
In addition, the implementation of a method to compute the gamma dose rate from a point source as done in fispact (manual appendix C.7.2 ) is relatively straightforward.
Before including this missing things I think it makes sense to start a draft PR to get some feedback and see if there is interest for these features and also avoid huge PRs. Moreoveer at a certain point could be good to have methods for the 3 methods mentioned in the discussion (fispact style, from Gamma-Ray Dose Constants, or using photon-flux-to-dose coefficients )
Checklist