Simplify rectangular lattice crossing and correctly handle corner checks

[GuySten]

Description

This PR simplify rectangular lattice crossing algorithm and add support for corner crossing.
The test case was taken from #2445 with lower resolution like #3355.

Fixes #3355 and fixes #2445.

Checklist

• I have performed a self-review of my own code
• I have run clang-format (version 15) on any C++ source files (if applicable)
• I have followed the style guidelines for Python source files (if applicable)
• I have made corresponding changes to the documentation (if applicable)
• I have added tests that prove my fix is effective or that my feature works (if applicable)

[nuclearkevin]

Thanks for resurrecting this @GuySten! I'll close #3355 once this is merged.

[GuySten]

@pshriwise, could you take some time to review this PR?
Without the added test it is a very small change (+12 -35 in lattice.cpp).

[pshriwise]

@pshriwise, could you take some time to review this PR?
Without the added test it is a very small change (+12 -35 in lattice.cpp).

Happy to. I was staring at it a bit this morning already in fact.

[paulromano]

Just made two updates here:

1. Added another guard against direction components being zero when setting lattice_trans
2. Cleaned up the model in the test

Good to go as far as I'm concerned! @pshriwise do you want to review before we merge?

[pshriwise]

Good to go as far as I'm concerned! @pshriwise do you want to review before we merge?

Nope! The two changes you noted to account for direction components that are zero are in and it seems the tests pass with the lost particle setting removed in the model -- the only other change I was going to suggest.

[gridley]

This is awesome; I'm delighted to see this resolved!