Fix hexagonal lattice orientation #3704
Closed
+31
−26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulromano
reviewed
Jan 6, 2026
Contributor
paulromano
left a comment
paulromano
left a comment
There was a problem hiding this comment.
I'm not in favor of changing behavior that will break backward compatibility. Looking at the original PR that added this (#1216), it was the intent that the y orientation corresponds to what is currently shown in #3537. So, I think a prudent course of action is to update the documentation of the orientation (which currently sounds like gibberish to me) to make clear what the 'x' and 'y' mean. I'll submit a PR today with a doc fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently Hexagonal lattice orientation is inverted with respect to what is documented.
This PR flip it.
Fixes #3537
Checklist
I have followed the style guidelines for Python source files (if applicable)I have made corresponding changes to the documentation (if applicable)I have added tests that prove my fix is effective or that my feature works (if applicable)