Skip to content

Conversation

@midhank
Copy link
Contributor

@midhank midhank commented Jul 30, 2025

Feature: Support "parameters" field in Subscription CRD is completed which allows passing parameters but the building blocks helm charts does not have parameter to support this

@cla-assistant
Copy link

cla-assistant bot commented Jul 30, 2025

CLA assistant check
All committers have signed the CLA.

@cla-assistant
Copy link

cla-assistant bot commented Jul 30, 2025

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@midhank midhank marked this pull request as draft August 4, 2025 03:10
@midhank midhank closed this Aug 4, 2025
@midhank midhank reopened this Aug 4, 2025
@midhank midhank marked this pull request as ready for review August 4, 2025 03:12
@sk31337
Copy link
Member

sk31337 commented Aug 4, 2025

@midhank thanks a lot for your contribution. Please add the helm-docs the new field at the values.yaml and an additional example in the values.ci.yaml.

After that, I will merge it.

@midhank
Copy link
Contributor Author

midhank commented Aug 6, 2025

@midhank thanks a lot for your contribution. Please add the helm-docs the new field at the values.yaml and an additional example in the values.ci.yaml.

After that, I will merge it.

Please review, I have updated based on review comments

@sk31337 sk31337 merged commit 13b418f into openmcp-project:main Aug 6, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants