Skip to content

Conversation

ricogu
Copy link
Contributor

@ricogu ricogu commented Sep 8, 2025

Summary

This PR introduces the possibility of binding secrets to a different namespace in the crossplane-gardener-shoot-clusters Helm chart.

Changes

  • Secret Namespace Configuration

    • Added support for specifying a custom secretNamespace for shoot clusters.
      • admin-kubeconfig-request.yaml template now uses .Values.shootClusters[].secretNamespace (defaults to "default" if not set).
      • Added secretNamespace field to both values.yaml and values.ci.yaml.
  • YAML Cleanup

    • Removed extra whitespace lines from manifest templates for AWS, Azure, and GCP shoot clusters.

Motivation

  • Enables users to bind connection secrets to custom namespaces.
  • Improves documentation and template clarity.

Impact

  • Existing clusters remain unaffected if they use the default namespace.
  • New clusters can specify their own secret binding namespace.

View the PR on GitHub

Copy link
Member

@sk31337 sk31337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ricogu looks very good for the initial contribution. Please change the hierarchy of secretNamespace to the following everywhere:

    adminKubeconfigRequest:
      secretNamespace: ""

@ricogu
Copy link
Contributor Author

ricogu commented Sep 9, 2025

@sk31337 , thanks for the review. I have adjusted the template, please have a look

@ricogu ricogu requested a review from sk31337 September 9, 2025 18:58
@sk31337 sk31337 merged commit 04fe71e into openmcp-project:main Sep 10, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants