feat: bind AccessRequest ServiceAccount to existing ClusterRole/Role #95
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maximiliantech
changed the title
This reverts commit 367ed72.
maximiliantech
changed the title
maximiliantech
commented
Sep 1, 2025
maximiliantech
commented
Sep 1, 2025
maximiliantech
requested review from
ValentinGerlach,
n3rdc4ptn,
reshnm and
robertgraeff
* bump cluster api dependency * refactor: adapt to new AccessRequest structure
reshnm
approved these changes
Sep 2, 2025
Diaphteiros
approved these changes
Sep 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR is the continuation of openmcp-project/openmcp-operator#128 and openmcp-project/openmcp-operator#137. It implements the logic to use
AccessRequest.spec.roleRefsto createClusterRoleBindings/RoleBindingsthat are bind to theAccessRequest's service account.We need this feature in openmcp-project/service-provider-crossplane#21 so that Flux has cluster-admin permissions (via
AccessRequest's service account) to successfully install Crossplane on an MCP.Which issue(s) this PR fixes:
Fixes openmcp-project/service-provider-crossplane#21
Related openmcp-project/openmcp-operator#128
Related openmcp-project/openmcp-operator#137
Special notes for your reviewer:
NONE
Release note: