Skip to content

Conversation

@moelsayed
Copy link
Contributor

The original repo for control-plane-operator didn't initially use the shared hack scripts used in the other components' repos. As a result, it has different make file targets and structure.

This PR add the the minimal necessary targets and scripts from the shared hack scripts to allow the github actions to pass successfully.

@maximiliantech
Copy link
Member

I would like to hold this PR back. We want to use https://github.com/openmcp-project/build for that. I already have the PR open to move the code openmcp-project/build#1. In the end we want to use the build repository as a git submodule in every operator repository including this one here. FYI: Instead of make we want to use Taskfiles and @Diaphteiros already prepared everything for it as described in the README there. We "just" have to include the repository here as a git submodule and then we can also get rid of the duplicate definitions and files.

Copy link
Member

@maximiliantech maximiliantech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, as this is a temporary solution and https://github.com/openmcp-project/build will be used afterwards in a follow-up PR.

@maximiliantech maximiliantech merged commit 210f632 into main Mar 17, 2025
7 checks passed
@maximiliantech maximiliantech deleted the fix_make2 branch March 18, 2025 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants