-
Notifications
You must be signed in to change notification settings - Fork 2
feat(releasechannel): add releasechannel ignore label #98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This pull request adds improved filtering logic to the GetOCMComponentsWithVersions
function to skip component versions based on labels and resource validation. The changes make the component selection process more robust by filtering out unwanted versions and handling edge cases.
- Adds filtering to skip component versions with the
openmcp.cloud/ignore
label set to"true"
- Implements validation to skip and log component versions that have no resources
- Introduces logging functionality with the
log
package import
Co-authored-by: Copilot <[email protected]>
What this PR does / why we need it:
This pull request introduces improved filtering and error handling in the
GetOCMComponentsWithVersions
function ininternal/ocm/ocm.go
. The changes ensure that component versions with specific labels are ignored, and that versions without resources are logged and skipped, making the component selection process more robust.Filtering and error handling improvements:
openmcp.cloud/ignore
set to"true"
, preventing them from being included in the results.Release note: