Skip to content

Conversation

@ValentinGerlach
Copy link
Member

@ValentinGerlach ValentinGerlach commented Oct 20, 2025

What this PR does / why we need it:

This PR removes the deprecated --oidc-use-pkce flag of the kubectl oidc-login get-token command and adds an option to configure the PKCE code challenge method.

It is a breaking change for other components that use the UsePKCE property in the CreateOIDCKubeconfig function parameters.

Release note:

breaking: replace deprecated PKCE flag

@ValentinGerlach ValentinGerlach changed the title fix: replace deprecated PKCE flag feat!: replace deprecated PKCE flag Oct 20, 2025
@ValentinGerlach ValentinGerlach marked this pull request as ready for review October 20, 2025 12:06
Copy link
Member

@maximiliantech maximiliantech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! Thank you @ValentinGerlach 🚀

@ValentinGerlach ValentinGerlach merged commit 59471d4 into main Oct 20, 2025
7 checks passed
@ValentinGerlach ValentinGerlach deleted the deprecated-pkce-flag branch October 20, 2025 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants