feat: extend webhook init logic #173
Merged
+182
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Diaphteiros
requested review from
ValentinGerlach,
maximiliantech,
reshnm and
robertgraeff
reshnm
approved these changes
Oct 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Our v1 controllers were deployed via helm charts, where the logic for creating the webhook
Serviceresource was part of the chart. Since this is not possible for controllers that are managed via provider resources, I extended the webhook init logic in this repo, so that it can be configured to create the webhook service.Which issue(s) this PR fixes:
Required for openmcp-project/project-workspace-operator#132
Special notes for your reviewer:
Release note: