Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion api/core/v1alpha1/apiserver_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ type APIServerStatus struct {
CommonComponentStatus `json:",inline"`

// ExternalAPIServerStatus contains the status of the external API server
*ExternalAPIServerStatus `json:",inline"`
ExternalAPIServerStatus `json:",inline"`

// AdminAccess is an admin kubeconfig for accessing the API server.
// +optional
Expand Down
4 changes: 2 additions & 2 deletions api/core/v1alpha1/authentication_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,8 @@ type ExternalAuthenticationStatus struct {

// AuthenticationStatus contains the status of the authentication component
type AuthenticationStatus struct {
CommonComponentStatus `json:",inline"`
*ExternalAuthenticationStatus `json:",inline"`
CommonComponentStatus `json:",inline"`
ExternalAuthenticationStatus `json:",inline"`
}

// IdentityProvider contains the configuration for an OpenID Connect identity provider
Expand Down
2 changes: 1 addition & 1 deletion api/core/v1alpha1/authorization_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ type ExternalAuthorizationStatus struct {
type AuthorizationStatus struct {
CommonComponentStatus `json:",inline"`
// ExternalAuthorizationStatus contains the status of the external authorization component
*ExternalAuthorizationStatus `json:",inline"`
ExternalAuthorizationStatus `json:",inline"`

// UserNamespaces is a list of namespaces that have been created by the user and
// must be managed by the authorization component.
Expand Down
4 changes: 2 additions & 2 deletions api/core/v1alpha1/cloudorchestrator_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,8 @@ type ExternalCloudOrchestratorStatus struct {

// CloudOrchestratorStatus defines the observed state of CloudOrchestrator
type CloudOrchestratorStatus struct {
CommonComponentStatus `json:",inline"`
*ExternalCloudOrchestratorStatus `json:",inline"`
CommonComponentStatus `json:",inline"`
ExternalCloudOrchestratorStatus `json:",inline"`

// Number of enabled components.
// +kubebuilder:validation:Optional
Expand Down
4 changes: 2 additions & 2 deletions api/core/v1alpha1/landscaper_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,8 @@ type ExternalLandscaperStatus struct {

// LandscaperStatus contains the landscaper status and potentially other fields which should not be exposed to the customer.
type LandscaperStatus struct {
CommonComponentStatus `json:",inline"`
*ExternalLandscaperStatus `json:",inline"`
CommonComponentStatus `json:",inline"`
ExternalLandscaperStatus `json:",inline"`

// LandscaperDeploymentInfo contains information about the corresponding LandscaperDeployment resource.
// +optional
Expand Down
30 changes: 5 additions & 25 deletions api/core/v1alpha1/zz_generated.deepcopy.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 1 addition & 2 deletions api/go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -11,14 +11,13 @@ require (
k8s.io/apimachinery v0.34.0
k8s.io/client-go v0.34.0
k8s.io/utils v0.0.0-20250820121507-0af2bda4dd1d
sigs.k8s.io/controller-runtime v0.21.0
sigs.k8s.io/controller-runtime v0.22.0
sigs.k8s.io/yaml v1.6.0
)

require (
github.com/Masterminds/semver/v3 v3.4.0 // indirect
github.com/beorn7/perks v1.0.1 // indirect
github.com/blang/semver/v4 v4.0.0 // indirect
github.com/cespare/xxhash/v2 v2.3.0 // indirect
github.com/davecgh/go-spew v1.1.2-0.20180830191138-d8f796af33cc // indirect
github.com/emicklei/go-restful/v3 v3.12.2 // indirect
Expand Down
6 changes: 2 additions & 4 deletions api/go.sum
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,6 @@ github.com/Masterminds/semver/v3 v3.4.0 h1:Zog+i5UMtVoCU8oKka5P7i9q9HgrJeGzI9SA1
github.com/Masterminds/semver/v3 v3.4.0/go.mod h1:4V+yj/TJE1HU9XfppCwVMZq3I84lprf4nC11bSS5beM=
github.com/beorn7/perks v1.0.1 h1:VlbKKnNfV8bJzeqoa4cOKqO6bYr3WgKZxO8Z16+hsOM=
github.com/beorn7/perks v1.0.1/go.mod h1:G2ZrVWU2WbWT9wwq4/hrbKbnv/1ERSJQ0ibhJ6rlkpw=
github.com/blang/semver/v4 v4.0.0 h1:1PFHFE6yCCTv8C1TeyNNarDzntLi7wMI5i/pzqYIsAM=
github.com/blang/semver/v4 v4.0.0/go.mod h1:IbckMUScFkM3pff0VJDNKRiT6TG/YpiHIM2yvyW5YoQ=
github.com/cespare/xxhash/v2 v2.3.0 h1:UL815xU9SqsFlibzuggzjXhog7bL6oX9BbNZnL2UFvs=
github.com/cespare/xxhash/v2 v2.3.0/go.mod h1:VGX0DQ3Q6kWi7AoAeZDth3/j3BFtOZR5XLFGgcrjCOs=
github.com/davecgh/go-spew v1.1.0/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38=
Expand Down Expand Up @@ -186,8 +184,8 @@ k8s.io/kube-openapi v0.0.0-20250710124328-f3f2b991d03b h1:MloQ9/bdJyIu9lb1PzujOP
k8s.io/kube-openapi v0.0.0-20250710124328-f3f2b991d03b/go.mod h1:UZ2yyWbFTpuhSbFhv24aGNOdoRdJZgsIObGBUaYVsts=
k8s.io/utils v0.0.0-20250820121507-0af2bda4dd1d h1:wAhiDyZ4Tdtt7e46e9M5ZSAJ/MnPGPs+Ki1gHw4w1R0=
k8s.io/utils v0.0.0-20250820121507-0af2bda4dd1d/go.mod h1:OLgZIPagt7ERELqWJFomSt595RzquPNLL48iOWgYOg0=
sigs.k8s.io/controller-runtime v0.21.0 h1:CYfjpEuicjUecRk+KAeyYh+ouUBn4llGyDYytIGcJS8=
sigs.k8s.io/controller-runtime v0.21.0/go.mod h1:OSg14+F65eWqIu4DceX7k/+QRAbTTvxeQSNSOQpukWM=
sigs.k8s.io/controller-runtime v0.22.0 h1:mTOfibb8Hxwpx3xEkR56i7xSjB+nH4hZG37SrlCY5e0=
sigs.k8s.io/controller-runtime v0.22.0/go.mod h1:FwiwRjkRPbiN+zp2QRp7wlTCzbUXxZ/D4OzuQUDwBHY=
sigs.k8s.io/json v0.0.0-20241014173422-cfa47c3a1cc8 h1:gBQPwqORJ8d8/YNZWEjoZs7npUVDpVXUUOFfW6CgAqE=
sigs.k8s.io/json v0.0.0-20241014173422-cfa47c3a1cc8/go.mod h1:mdzfpAEoE6DHQEN0uh9ZbOCuHbLK5wOm7dK4ctXE9Tg=
sigs.k8s.io/randfill v1.0.0 h1:JfjMILfT8A6RbawdsK2JXGBR5AQVfd+9TbzrlneTyrU=
Expand Down
2 changes: 1 addition & 1 deletion go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ require (
k8s.io/apimachinery v0.34.0
k8s.io/client-go v0.34.0
k8s.io/utils v0.0.0-20250820121507-0af2bda4dd1d
sigs.k8s.io/controller-runtime v0.21.0
sigs.k8s.io/controller-runtime v0.22.0
sigs.k8s.io/yaml v1.6.0
)

Expand Down
7 changes: 2 additions & 5 deletions go.sum
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,6 @@ github.com/apparentlymart/go-cidr v1.1.0 h1:2mAhrMoF+nhXqxTzSZMUzDHkLjmIHC+Zzn4t
github.com/apparentlymart/go-cidr v1.1.0/go.mod h1:EBcsNrHc3zQeuaeCeCtQruQm+n9/YjEn/vI25Lg7Gwc=
github.com/beorn7/perks v1.0.1 h1:VlbKKnNfV8bJzeqoa4cOKqO6bYr3WgKZxO8Z16+hsOM=
github.com/beorn7/perks v1.0.1/go.mod h1:G2ZrVWU2WbWT9wwq4/hrbKbnv/1ERSJQ0ibhJ6rlkpw=
github.com/blang/semver v3.5.1+incompatible h1:cQNTCjp13qL8KC3Nbxr/y2Bqb63oX6wdnnjpJbkM4JQ=
github.com/blang/semver/v4 v4.0.0 h1:1PFHFE6yCCTv8C1TeyNNarDzntLi7wMI5i/pzqYIsAM=
github.com/blang/semver/v4 v4.0.0/go.mod h1:IbckMUScFkM3pff0VJDNKRiT6TG/YpiHIM2yvyW5YoQ=
github.com/cespare/xxhash/v2 v2.3.0 h1:UL815xU9SqsFlibzuggzjXhog7bL6oX9BbNZnL2UFvs=
github.com/cespare/xxhash/v2 v2.3.0/go.mod h1:VGX0DQ3Q6kWi7AoAeZDth3/j3BFtOZR5XLFGgcrjCOs=
github.com/cpuguy83/go-md2man/v2 v2.0.6/go.mod h1:oOW0eioCTA6cOiMLiUPZOpcVxMig6NIQQ7OS05n1F4g=
Expand Down Expand Up @@ -266,8 +263,8 @@ k8s.io/kube-openapi v0.0.0-20250710124328-f3f2b991d03b h1:MloQ9/bdJyIu9lb1PzujOP
k8s.io/kube-openapi v0.0.0-20250710124328-f3f2b991d03b/go.mod h1:UZ2yyWbFTpuhSbFhv24aGNOdoRdJZgsIObGBUaYVsts=
k8s.io/utils v0.0.0-20250820121507-0af2bda4dd1d h1:wAhiDyZ4Tdtt7e46e9M5ZSAJ/MnPGPs+Ki1gHw4w1R0=
k8s.io/utils v0.0.0-20250820121507-0af2bda4dd1d/go.mod h1:OLgZIPagt7ERELqWJFomSt595RzquPNLL48iOWgYOg0=
sigs.k8s.io/controller-runtime v0.21.0 h1:CYfjpEuicjUecRk+KAeyYh+ouUBn4llGyDYytIGcJS8=
sigs.k8s.io/controller-runtime v0.21.0/go.mod h1:OSg14+F65eWqIu4DceX7k/+QRAbTTvxeQSNSOQpukWM=
sigs.k8s.io/controller-runtime v0.22.0 h1:mTOfibb8Hxwpx3xEkR56i7xSjB+nH4hZG37SrlCY5e0=
sigs.k8s.io/controller-runtime v0.22.0/go.mod h1:FwiwRjkRPbiN+zp2QRp7wlTCzbUXxZ/D4OzuQUDwBHY=
sigs.k8s.io/controller-tools v0.16.5 h1:5k9FNRqziBPwqr17AMEPPV/En39ZBplLAdOwwQHruP4=
sigs.k8s.io/controller-tools v0.16.5/go.mod h1:8vztuRVzs8IuuJqKqbXCSlXcw+lkAv/M2sTpg55qjMY=
sigs.k8s.io/json v0.0.0-20241014173422-cfa47c3a1cc8 h1:gBQPwqORJ8d8/YNZWEjoZs7npUVDpVXUUOFfW6CgAqE=
Expand Down
2 changes: 1 addition & 1 deletion internal/components/apiserver.go
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ func (*APIServerConverter) ConvertToResourceSpec(mcp *openmcpv1alpha1.ManagedCon

// InjectStatus implements ComponentConverter.
func (*APIServerConverter) InjectStatus(raw any, mcpStatus *openmcpv1alpha1.ManagedControlPlaneStatus) error {
status, ok := raw.(*openmcpv1alpha1.ExternalAPIServerStatus)
status, ok := raw.(openmcpv1alpha1.ExternalAPIServerStatus)
if !ok {
return openmcperrors.ErrWrongComponentStatusType
}
Expand Down
4 changes: 2 additions & 2 deletions internal/components/apiserver_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -112,14 +112,14 @@ var _ = Describe("APIServerConverter", func() {
Context("InjectStatus", func() {
It("should inject the status", func() {
conv := &components.APIServerConverter{}
status := &openmcpv1alpha1.ExternalAPIServerStatus{}
status := openmcpv1alpha1.ExternalAPIServerStatus{}

mcpStatus := &openmcpv1alpha1.ManagedControlPlaneStatus{}

err := conv.InjectStatus(status, mcpStatus)
Expect(err).ToNot(HaveOccurred())
Expect(mcpStatus.Components.APIServer).ToNot(BeNil())
Expect(mcpStatus.Components.APIServer).To(Equal(status))
Expect(*mcpStatus.Components.APIServer).To(Equal(status))
})

It("should not inject an incompatible status", func() {
Expand Down
2 changes: 1 addition & 1 deletion internal/components/authentication.go
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ func (ac *AuthenticationConverter) ConvertToResourceSpec(mcp *openmcpv1alpha1.Ma

// InjectStatus implements ComponentConverter.
func (ac *AuthenticationConverter) InjectStatus(raw any, mcpStatus *openmcpv1alpha1.ManagedControlPlaneStatus) error {
status, ok := raw.(*openmcpv1alpha1.ExternalAuthenticationStatus)
status, ok := raw.(openmcpv1alpha1.ExternalAuthenticationStatus)
if !ok {
return openmcperrors.ErrWrongComponentStatusType
}
Expand Down
4 changes: 2 additions & 2 deletions internal/components/authentication_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ var _ = Describe("AuthenticationConverter", func() {
Context("InjectStatus", func() {
It("should inject the status", func() {
conv := &components.AuthenticationConverter{}
status := &openmcpv1alpha1.ExternalAuthenticationStatus{
status := openmcpv1alpha1.ExternalAuthenticationStatus{
UserAccess: &openmcpv1alpha1.SecretReference{
NamespacedObjectReference: openmcpv1alpha1.NamespacedObjectReference{
Name: "test",
Expand All @@ -120,7 +120,7 @@ var _ = Describe("AuthenticationConverter", func() {
err := conv.InjectStatus(status, mcpStatus)
Expect(err).ToNot(HaveOccurred())
Expect(mcpStatus.Components.Authentication).ToNot(BeNil())
Expect(mcpStatus.Components.Authentication).To(Equal(status))
Expect(*mcpStatus.Components.Authentication).To(Equal(status))
})

It("should not inject an incompatible status", func() {
Expand Down
2 changes: 1 addition & 1 deletion internal/components/authorization.go
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ func (ac *AuthorizationConverter) ConvertToResourceSpec(mcp *openmcpv1alpha1.Man

// InjectStatus implements ComponentConverter.
func (ac *AuthorizationConverter) InjectStatus(raw any, mcpStatus *openmcpv1alpha1.ManagedControlPlaneStatus) error {
status, ok := raw.(*openmcpv1alpha1.ExternalAuthorizationStatus)
status, ok := raw.(openmcpv1alpha1.ExternalAuthorizationStatus)
if !ok {
return openmcperrors.ErrWrongComponentStatusType
}
Expand Down
4 changes: 2 additions & 2 deletions internal/components/authorization_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -146,11 +146,11 @@ var _ = Describe("AuthorizationConverter", func() {
It("should inject the status", func() {
conv := &components.AuthorizationConverter{}
mcpStatus := &openmcpv1alpha1.ManagedControlPlaneStatus{}
status := &openmcpv1alpha1.ExternalAuthorizationStatus{}
status := openmcpv1alpha1.ExternalAuthorizationStatus{}

err := conv.InjectStatus(status, mcpStatus)
Expect(err).ToNot(HaveOccurred())
Expect(mcpStatus.Components.Authorization).To(Equal(status))
Expect(*mcpStatus.Components.Authorization).To(Equal(status))
})

It("should fail to inject the status", func() {
Expand Down
2 changes: 1 addition & 1 deletion internal/components/cloudorchestrator.go
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ func (*CloudOrchestratorConverter) ConvertToResourceSpec(mcp *openmcpv1alpha1.Ma

// InjectStatus implements ComponentConverter.
func (*CloudOrchestratorConverter) InjectStatus(raw any, mcpStatus *openmcpv1alpha1.ManagedControlPlaneStatus) error {
status, ok := raw.(*openmcpv1alpha1.ExternalCloudOrchestratorStatus)
status, ok := raw.(openmcpv1alpha1.ExternalCloudOrchestratorStatus)
if !ok {
return openmcperrors.ErrWrongComponentStatusType
}
Expand Down
4 changes: 2 additions & 2 deletions internal/components/cloudorchestrator_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -77,11 +77,11 @@ var _ = Describe("CloudOrchestratorConverter", func() {
It("should inject the status", func() {
conv := &components.CloudOrchestratorConverter{}
mcpStatus := &openmcpv1alpha1.ManagedControlPlaneStatus{}
status := &openmcpv1alpha1.ExternalCloudOrchestratorStatus{}
status := openmcpv1alpha1.ExternalCloudOrchestratorStatus{}

err := conv.InjectStatus(status, mcpStatus)
Expect(err).ToNot(HaveOccurred())
Expect(mcpStatus.Components.CloudOrchestrator).To(Equal(status))
Expect(*mcpStatus.Components.CloudOrchestrator).To(Equal(status))
})

It("should fail to inject the status", func() {
Expand Down
2 changes: 1 addition & 1 deletion internal/components/landscaper.go
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ func (*LandscaperConverter) ConvertToResourceSpec(mcp *openmcpv1alpha1.ManagedCo

// InjectStatus implements ComponentConverter.
func (*LandscaperConverter) InjectStatus(raw any, mcpStatus *openmcpv1alpha1.ManagedControlPlaneStatus) error {
status, ok := raw.(*openmcpv1alpha1.ExternalLandscaperStatus)
status, ok := raw.(openmcpv1alpha1.ExternalLandscaperStatus)
if !ok {
return openmcperrors.ErrWrongComponentStatusType
}
Expand Down
4 changes: 2 additions & 2 deletions internal/components/landscaper_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -82,11 +82,11 @@ var _ = Describe("LandscaperConverter", func() {
It("should inject the status", func() {
conv := &components.LandscaperConverter{}
mcpStatus := &openmcpv1alpha1.ManagedControlPlaneStatus{}
status := &openmcpv1alpha1.ExternalLandscaperStatus{}
status := openmcpv1alpha1.ExternalLandscaperStatus{}

err := conv.InjectStatus(status, mcpStatus)
Expect(err).ToNot(HaveOccurred())
Expect(mcpStatus.Components.Landscaper).To(Equal(status))
Expect(*mcpStatus.Components.Landscaper).To(Equal(status))
})

It("should not inject an incompatible status", func() {
Expand Down
4 changes: 2 additions & 2 deletions internal/controller/core/apiserver/controller_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -276,7 +276,7 @@ var _ = Describe("CO-1153 APIServer Controller", func() {
Raw: []byte(`{"apiVersion":"garden.sapcloud.io/v1beta1","kind":"Shoot","metadata":{"name":"foo","namespace":"bar"}}`),
},
}
dps.ExternalAPIServerStatus = &openmcpv1alpha1.ExternalAPIServerStatus{
dps.ExternalAPIServerStatus = openmcpv1alpha1.ExternalAPIServerStatus{
Endpoint: "https://k8s-external.ondemand.com",
ServiceAccountIssuer: "https://k8s-sa.ondemand.com",
}
Expand Down Expand Up @@ -311,7 +311,7 @@ var _ = Describe("CO-1153 APIServer Controller", func() {
Raw: []byte(`{"apiVersion":"garden.sapcloud.io/v1beta1","kind":"Shoot","metadata":{"name":"foo","namespace":"bar"}}`),
},
}
dps.ExternalAPIServerStatus = &openmcpv1alpha1.ExternalAPIServerStatus{
dps.ExternalAPIServerStatus = openmcpv1alpha1.ExternalAPIServerStatus{
Endpoint: "https://k8s-external.ondemand.com",
ServiceAccountIssuer: "https://k8s-sa.ondemand.com",
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -204,9 +204,6 @@ func (gc *GardenerConnector) HandleCreateOrUpdate(ctx context.Context, as *openm
}
}

if status.ExternalAPIServerStatus == nil {
status.ExternalAPIServerStatus = &openmcpv1alpha1.ExternalAPIServerStatus{}
}
for _, endpoint := range sh.Status.AdvertisedAddresses {
switch endpoint.Name {
case constants.AdvertisedAddressExternal:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -154,10 +154,8 @@ var _ = Describe("APIServer Gardener Conversion", func() {
_, usf, _, err := gc.HandleCreateOrUpdate(env.Ctx, as, nil)
Expect(err).ToNot(HaveOccurred())
Expect(usf).ToNot(BeNil())
if as.Status.ExternalAPIServerStatus != nil {
Expect(as.Status.ExternalAPIServerStatus.Endpoint).To(BeEmpty())
Expect(as.Status.ExternalAPIServerStatus.ServiceAccountIssuer).To(BeEmpty())
}
Expect(as.Status.ExternalAPIServerStatus.Endpoint).To(BeEmpty())
Expect(as.Status.ExternalAPIServerStatus.ServiceAccountIssuer).To(BeEmpty())
Expect(usf(&as.Status)).To(Succeed())
Expect(as.Status.ExternalAPIServerStatus.Endpoint).To(Equal(expectedEndpoint))
Expect(as.Status.ExternalAPIServerStatus.ServiceAccountIssuer).To(Equal(expectedServiceAccountIssuer))
Expand Down
3 changes: 0 additions & 3 deletions internal/controller/core/apiserver/v2.go
Original file line number Diff line number Diff line change
Expand Up @@ -185,9 +185,6 @@ func v2HandleCreateOrUpdate(ctx context.Context, as *openmcpv1alpha1.APIServer,
// build the UpdateStatusFunc
apiAccess := &openmcpv1alpha1.APIServerAccess{}
var usf handler.UpdateStatusFunc = func(status *openmcpv1alpha1.APIServerStatus) error {
if status.ExternalAPIServerStatus == nil {
status.ExternalAPIServerStatus = &openmcpv1alpha1.ExternalAPIServerStatus{}
}
if setShootInStatus != nil {
if err := setShootInStatus(status); err != nil {
return fmt.Errorf("error setting shoot in status: %w", err)
Expand Down
4 changes: 0 additions & 4 deletions internal/controller/core/authentication/controller.go
Original file line number Diff line number Diff line change
Expand Up @@ -479,10 +479,6 @@ func (ar *AuthenticationReconciler) ensureAccessSecret(ctx context.Context, expe
// updateExternalStatus updates the external status of the Authentication resource
// by creating a kubeconfig for the user access to the APIServer
func (ar *AuthenticationReconciler) updateExternalStatus(ctx context.Context, auth *openmcpv1alpha1.Authentication) error {
if auth.Status.ExternalAuthenticationStatus == nil {
auth.Status.ExternalAuthenticationStatus = &openmcpv1alpha1.ExternalAuthenticationStatus{}
}

// try to get access secret
accessSecret := getSecretAccessor(auth)

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -362,7 +362,7 @@ var _ = Describe("CO-1153 ManagedControlPlane Controller", func() {
time.Sleep(1 * time.Second) // without this, it cannot be verified that the lastTransitionTime is not updated if nothing changes, because the test is too fast for the second precision of the timestamps

// verify status
Expect(mcp.Status.Components.Authentication).To(Equal(auth.Status.ExternalAuthenticationStatus))
Expect(*mcp.Status.Components.Authentication).To(Equal(auth.Status.ExternalAuthenticationStatus))

// verify conditions
Expect(mcp.Status.Conditions).To(ConsistOf(
Expand Down
Loading