feat: add created-by annotation to ManagedControlPlane
#56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
|
maximiliantech
changed the title
created-by annotation to ManagedControlPlane
maximiliantech
changed the title
created-by annotation to ManagedControlPlanecreated-by annotation to ManagedControlPlane
On-behalf-of: SAP <[email protected]> Signed-off-by: Zoltan Szabo <[email protected]>
On-behalf-of: SAP <[email protected]> Signed-off-by: Zoltan Szabo <[email protected]>
maximiliantech
force-pushed
the
created-by-annotation
branch
from
6228f16 to
4fd8deb
Compare
maximiliantech
approved these changes
May 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
A webhook has been implemented on the resources Project and Workspace, adding the core.openmcp.cloud/created-by annotation to the resource upon creation.
This is missing for the ManagedControlPlane resource.
Which issue(s) this PR fixes:
Fixes #44
Special notes for your reviewer:
Release note: