Skip to content

Fix remote cluster access ref #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 23, 2025
Merged

Fix remote cluster access ref #19

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5fe9108
change interval name and fix examples
mirzakopic May 23, 2025
b1e6b22
fix remote ca ref, needs to be optional
mirzakopic May 23, 2025
13300a7
fix remote ca ref, needs to be optional nil
mirzakopic May 23, 2025
84e9e01
fix remote ca ref, needs to be optional nil
mirzakopic May 23, 2025
36bc467
fix remote ca ref, needs to be optional nil
mirzakopic May 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion api/v1alpha1/managedmetric_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,8 @@ type ManagedMetricSpec struct {
// +kubebuilder:default:="10m"
Interval metav1.Duration `json:"interval,omitempty"`

RemoteClusterAccessRef `json:"remoteClusterAccessRef,omitempty"`
// +optional
*RemoteClusterAccessRef `json:"remoteClusterAccessRef,omitempty"`
}

// ManagedObservation represents the latest available observation of an object's state
Expand Down
3 changes: 2 additions & 1 deletion api/v1alpha1/metric_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,8 @@ type MetricSpec struct {
// +kubebuilder:default:="10m"
Interval metav1.Duration `json:"interval,omitempty"`

RemoteClusterAccessRef `json:"remoteClusterAccessRef,omitempty"`
// +optional
*RemoteClusterAccessRef `json:"remoteClusterAccessRef,omitempty"`

Projections []Projection `json:"projections,omitempty"`
}
Expand Down
14 changes: 11 additions & 3 deletions api/v1alpha1/zz_generated.deepcopy.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion internal/controller/managedmetric_controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ func (r *ManagedMetricReconciler) Reconcile(ctx context.Context, req ctrl.Reques
/*
1.2 Create QueryConfig to query the resources in the K8S cluster or external cluster based on the kubeconfig secret reference
*/
queryConfig, err := createQueryConfig(ctx, &metric.Spec.RemoteClusterAccessRef, r)
queryConfig, err := createQueryConfig(ctx, metric.Spec.RemoteClusterAccessRef, r)
if err != nil {
return ctrl.Result{RequeueAfter: RequeueAfterError}, err
}
Expand Down
2 changes: 1 addition & 1 deletion internal/controller/metric_controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ func (r *MetricReconciler) Reconcile(ctx context.Context, req ctrl.Request) (ctr
/*
1.2 Create QueryConfig to query the resources in the K8S cluster or external cluster based on the kubeconfig secret reference
*/
queryConfig, err := createQC(ctx, &metric.Spec.RemoteClusterAccessRef, r)
queryConfig, err := createQC(ctx, metric.Spec.RemoteClusterAccessRef, r)
if err != nil {
return ctrl.Result{RequeueAfter: RequeueAfterError}, err
}
Expand Down
Loading