feat(datasinkref): openapi schema spec defaulting #80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
empty object triggers nested defaulting when no dataSinkRef is provided On-behalf-of: @SAP [email protected] Signed-off-by: Christopher Junk <[email protected]>
christophrj
force-pushed
the
feat/enhance-datasinkref-defaulting
branch
from
2ba8729 to
afce4e2
Compare
GenosseOtt
approved these changes
Sep 19, 2025
maximiliantech
approved these changes
Sep 23, 2025
There was a problem hiding this comment.
Great work @christophrj 🚀 I really appreciate your contribution 🫶
That is totally fine by me! Thanks for putting your thoughts into this 🏋️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR introduces basic api server defaulting for the data sink reference of all metric types.
Fixes #30
Special notes for your reviewer:
The empty object in the parent struct triggers the defaulting when no dataSinkRef is provided.
Note that this doesn't cover the case of a user explicitly specifying a data sink with an empty string ("") which is handled in the controller but there is no proper way to handle this in openapi. minLength=1 would be a potential workaround but this felt like such an edge case that i left it out and i definitely would not introduce a mutating webhook for this.
Release note: