feat: MCPv2 controller #115
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
Diaphteiros
force-pushed
the
mcp-controller
branch
4 times, most recently
from
7899415 to
3808e8f
Compare
Diaphteiros
requested review from
ValentinGerlach,
maximiliantech,
reshnm and
robertgraeff
Diaphteiros
force-pushed
the
mcp-controller
branch
from
7b42d35 to
484fb50
Compare
ValentinGerlach
approved these changes
Sep 3, 2025
Comment on lines
+72
to
+75
| if !cr.GetDeletionTimestamp().IsZero() { | ||
| log.Debug("ClusterRequest resource already marked for deletion", "crName", crName, "namespace", cr.GetNamespace()) | ||
| continue | ||
| } |
There was a problem hiding this comment.
Deleting a resource is idempotent so this check is not needed. But we can keep it if you think the debug message could be useful.
There was a problem hiding this comment.
Yes, this is more about the debug message than about preventing a duplicate deletion.
| log.Debug("Labels on MCP namespace on platform cluster do not match expected labels, skipping deletion", "platformNamespace", ns.Name) | ||
| } else { | ||
| if !ns.DeletionTimestamp.IsZero() { | ||
| log.Debug("MCP namespace already marked for deletion", "platformNamespace", ns.Name) |
| remainingServiceResources := []*unstructured.Unstructured{} | ||
| for _, res := range serviceResources { | ||
| if !res.GetDeletionTimestamp().IsZero() { | ||
| log.Debug("Service resource already marked for deletion", "resourceKind", res.GetKind(), "resourceAPIVersion", res.GetAPIVersion(), "provider", providerName) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Implements the MCP v2 controller.
Which issue(s) this PR fixes:
Main part of openmcp-project/backlog#210
Special notes for your reviewer:
Depends on #114 and requires it to be merged first.
Release note: