feat(deployment): add ExtraVolumes and ExtraVolumeMounts to DeploymentSpec
#118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maximiliantech
changed the title
Volumes and ExtraVolumes to DeploymentSpecExtraVolumes and ExtraVolumesMounts to DeploymentSpec
maximiliantech
changed the title
ExtraVolumes and ExtraVolumesMounts to DeploymentSpecExtraVolumes and ExtraVolumeMounts to DeploymentSpec
ValentinGerlach
approved these changes
Aug 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
For cluster-provider-kind, we need to pass down values for
ExtraVolumesandExtraVolumeMountsto thePodSpecof the Cluster Provider Deployment, see cluster-provider-kind (How it works). This PR adds the fieldsExtraVolumesandExtraVolumeMountsto theDeploymentSpec.Additionally, this PR fixes a small bug that occurred while working on openmcp-project/cluster-provider-kind#66. During start up of the cluster-provider-kind, the init job did not have the necessary permissions to create
ClusterProfileson the Platform cluster.89a3230(#118) fixes this.Which issue(s) this PR fixes:
NONE
Special notes for your reviewer:
The PR might seem very big, but the biggest chunk of changes originates in the embedding of the
[]corev1.Volumeand[]corev1.VolumeMountfromk8s.io/api/core/v1go package.Release note: