Skip to content

Conversation

@robertgraeff
Copy link
Member

@robertgraeff robertgraeff commented Aug 28, 2025

What this PR does / why we need it:

Since PR #126, all providers are installed in the openmcp-system namespace. To avoid name conflicts, function CreateAndWaitForCluster now prefixes the names of ClusterRequests and AccessRequests with the provider name. I.e. they now have the format <provider name>--<local name> where the local name could for example be onboarding or onboarding-init.

Examples of resulting names:

crossplane.services.openmcp.cloud--onboarding-init
crossplane.services.openmcp.cloud--onboarding
provider.landscaper.services.openmcp.cloud--onboarding-init
provider.landscaper.services.openmcp.cloud--onboarding

Therefore, if two providers choose the same local name onboarding there is no name conflict.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

- Prevent name conflicts for ClusterRequests and AccessRequests

@robertgraeff robertgraeff merged commit 5502ed0 into main Aug 28, 2025
6 checks passed
@robertgraeff robertgraeff deleted the feat/cluster-and-access-request-names branch August 28, 2025 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants