Skip to content

fix: remove namespace from ClusterProfile's provider and providerconfig references #138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 1, 2025
Merged

fix: remove namespace from ClusterProfile's provider and providerconfig references #138

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions api/clusters/v1alpha1/clusterprofile_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,10 @@ import (
// ClusterProfileSpec defines the desired state of Provider.
type ClusterProfileSpec struct {
// ProviderRef is a reference to the ClusterProvider
ProviderRef commonapi.ObjectReference `json:"providerRef"`
ProviderRef commonapi.LocalObjectReference `json:"providerRef"`

// ProviderConfigRef is a reference to the provider-specific configuration.
ProviderConfigRef commonapi.ObjectReference `json:"providerConfigRef"`
ProviderConfigRef commonapi.LocalObjectReference `json:"providerConfigRef"`

// SupportedVersions are the supported Kubernetes versions.
SupportedVersions []SupportedK8sVersion `json:"supportedVersions"`
Expand Down
30 changes: 16 additions & 14 deletions api/crds/manifests/clusters.openmcp.cloud_clusterprofiles.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,28 +55,30 @@ spec:
configuration.
properties:
name:
description: Name is the name of the object.
default: ""
description: |-
Name of the referent.
This field is effectively required, but due to backwards compatibility is
allowed to be empty. Instances of this type with an empty value here are
almost certainly wrong.
More info: https://kubernetes.io/docs/concepts/overview/working-with-objects/names/#names
type: string
namespace:
description: Namespace is the namespace of the object.
type: string
required:
- name
- namespace
type: object
x-kubernetes-map-type: atomic
providerRef:
description: ProviderRef is a reference to the ClusterProvider
properties:
name:
description: Name is the name of the object.
type: string
namespace:
description: Namespace is the namespace of the object.
default: ""
description: |-
Name of the referent.
This field is effectively required, but due to backwards compatibility is
allowed to be empty. Instances of this type with an empty value here are
almost certainly wrong.
More info: https://kubernetes.io/docs/concepts/overview/working-with-objects/names/#names
type: string
required:
- name
- namespace
type: object
x-kubernetes-map-type: atomic
supportedVersions:
description: SupportedVersions are the supported Kubernetes versions.
items:
Expand Down