Skip to content

Conversation

@Diaphteiros
Copy link
Contributor

What this PR does / why we need it:
Removes the superfluous namespace field from the secret reference in the AccessRequest status. AccessRequest secrets are expected to be created in the same namespace as the AccessRequest itself, so this field is not needed. It was added by accident when we unified the reference types.

Which issue(s) this PR fixes:
Fixes #103

Special notes for your reviewer:
⚠️ This is a breaking change. While it should have no impact regarding existing resources, because all currently existing ClusterProviders create the AccessRequest secrets in the same namespace as the AccessRequest, all controllers that read the secret reference will require minor code changes.

Let's choose a good point in time to merge this.

Release note:

Removed the `status.secretRef.namespace` field from `AccessRequest` resources which was added by accident. The access secrets are expected to be in the same namespace as the AccessRequest itself, so wherever this field is read, it can just be replaced with the AccessRequest's namespace.

@robertgraeff robertgraeff merged commit dc0e743 into main Oct 23, 2025
5 checks passed
@robertgraeff robertgraeff deleted the ar-secretref branch October 23, 2025 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

remove namespace field from status.secretRef in AccessRequests

5 participants