remove namespace field from secret reference in AccessRequest status #183
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Removes the superfluous
namespacefield from the secret reference in the AccessRequest status. AccessRequest secrets are expected to be created in the same namespace as the AccessRequest itself, so this field is not needed. It was added by accident when we unified the reference types.Which issue(s) this PR fixes:
Fixes #103
Special notes for your reviewer:
⚠️ This is a breaking change. While it should have no impact regarding existing resources, because all currently existing ClusterProviders create the AccessRequest secrets in the same namespace as the AccessRequest, all controllers that read the secret reference will require minor code changes.
Let's choose a good point in time to merge this.
Release note: