fix!: small threat modelling issues #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes threat modelling issues by removing deprecated endpoints and unused JSONPath functionality.
- Removed endpoints: "/.well-known/openmcp/kubeconfig" and "/btp-so".
- Eliminated the unused JSONPath header and related processing in favor of JQ handling.
- Updated the routing and handler implementations to support the breaking change, requiring frontend v0.2.0 and above.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| internal/server/server.go | Removed routing for kubeconfig and btp-so endpoints. |
| internal/server/handlerWellKnownKubeconfig.go | Removed the kubeconfig handler implementation. |
| internal/server/handlerMain.go | Removed JSONPath header processing and logic; now solely using JQ. |
| internal/server/handlerCategory.go | Removed JSONPath branch in conditional response handling. |
| internal/server/handlerBtpSO.go | Removed the btp-so handler implementation. |
Comments suppressed due to low confidence (1)
internal/server/server.go:16
- The removal of the kubeconfig and btp-so endpoints is a breaking change; ensure that the frontend integration and API documentation are updated accordingly.
mux.HandleFunc("/.well-known/openmcp/kubeconfig", defaultHandler(shared, wellKnownKubeconfigHandler))
n3rdc4ptn
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issues of the threat modelling.
removes endpoints:
btp-sonot needed/usedkubeconfignot needed anymore, as oidc informtion is now provided in the frontend directlyAlso removed the jsonpath header option as it wasn't used.
The kubeconfig endpoint removal is a breaking change and makes the backend only compatible with frontend version v0.2.0 and above as it needs the feature: openmcp-project/ui-frontend#77.