Skip to content

Conversation

lucasgoral
Copy link
Contributor

@lucasgoral lucasgoral commented May 8, 2025

What this PR does / why we need it:

This PR add feature to display YAMLs of the MCP resources.

@lucasgoral lucasgoral marked this pull request as ready for review May 15, 2025 10:29
@andreaskienle andreaskienle self-assigned this May 15, 2025
Copy link
Contributor

@andreaskienle andreaskienle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really good now, especially the table layouts and the YAML button 🎉

I have a few smaller suggestions that I marked below. Additionally, I noticed something unexpected with the projects table: When opening the YAML dialog and clicking inside it, it unexpectedly navigates to the project because onRowClick is triggered. I could swear it behaved differently yesterday. Are you seeing the same thing?

I found a potential workaround by adding onClick={(e) => e.stopPropagation()} to the dialog component 😬

Copy link

cla-assistant bot commented May 16, 2025

CLA assistant check
All committers have signed the CLA.

Copy link

cla-assistant bot commented May 16, 2025

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@lucasgoral
Copy link
Contributor Author

This looks really good now, especially the table layouts and the YAML button 🎉

I have a few smaller suggestions that I marked below. Additionally, I noticed something unexpected with the projects table: When opening the YAML dialog and clicking inside it, it unexpectedly navigates to the project because onRowClick is triggered. I could swear it behaved differently yesterday. Are you seeing the same thing?

I found a potential workaround by adding onClick={(e) => e.stopPropagation()} to the dialog component 😬

Thank you for spotting. Fixed. :)

@lucasgoral lucasgoral requested a review from andreaskienle May 20, 2025 07:19
andreaskienle
andreaskienle previously approved these changes May 20, 2025
Copy link
Contributor

@andreaskienle andreaskienle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! 👍🏻

About the 90% width in ⁠YamlViewer: do you see any specific use cases for it? It feels a bit unusual to me.

@lucasgoral lucasgoral merged commit 6f839e5 into main May 20, 2025
4 of 5 checks passed
@lucasgoral lucasgoral deleted the feature/display-resource-yaml-for-mcp- branch May 20, 2025 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants