-
Notifications
You must be signed in to change notification settings - Fork 3
Feature/display resource yaml for mcp #105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ub.com/openmcp-project/ui-frontend into feature/display-resource-yaml-for-mcp-
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks really good now, especially the table layouts and the YAML button 🎉
I have a few smaller suggestions that I marked below. Additionally, I noticed something unexpected with the projects table: When opening the YAML dialog and clicking inside it, it unexpectedly navigates to the project because onRowClick
is triggered. I could swear it behaved differently yesterday. Are you seeing the same thing?
I found a potential workaround by adding onClick={(e) => e.stopPropagation()}
to the dialog component 😬
|
Thank you for spotting. Fixed. :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! 👍🏻
About the 90% width in YamlViewer: do you see any specific use cases for it? It feels a bit unusual to me.
What this PR does / why we need it:
This PR add feature to display YAMLs of the MCP resources.