Skip to content

Fluxlist undefined error fix #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 21, 2025
Merged

Fluxlist undefined error fix #118

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion public/locales/en.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,8 @@
"tableVersionHeader": "Revision",
"noFluxError": "Please install flux to view this component",
"gitOpsTitle": "GitOps",
"kustomizationsTitle": "Kustomizations"
"kustomizationsTitle": "Kustomizations",
"undefinedError": "Something went wrong"
Copy link
Contributor

@lucasgoral lucasgoral May 21, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I understand this is displayed when there is no repoErr?.message or kustomizationErr?.message but is it possible to change it to more meaningful message?

},
"ProvidersList": {
"tableNameHeader": "Name",
Expand Down
6 changes: 5 additions & 1 deletion src/components/ControlPlane/FluxList.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,11 @@ export default function FluxList() {
if (repoErr || kustomizationErr) {
return (
<IllustratedError
details={repoErr.message || kustomizationErr.message}
details={
repoErr?.message ||
kustomizationErr?.message ||
t('FluxList.undefinedError')
}
title={t('FluxList.noFluxError')}
/>
);
Expand Down
Loading