-
Notifications
You must be signed in to change notification settings - Fork 3
feat: add multi-arch release images #134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR enhances image build pipelines by enabling multi-architecture support and consolidating provenance settings.
- Adds QEMU and Docker Buildx setup steps for cross-platform builds in the release workflow
- Enables building and pushing images for both
amd64
andarm64
architectures - Removes explicit
provenance: mode=max
flag (now defaulted)
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
File | Description |
---|---|
.github/workflows/on-release.yaml | Added QEMU/Buildx setup and platforms for multi-arch |
.github/workflows/main.yaml | Removed explicit provenance setting |
Comments suppressed due to low confidence (1)
.github/workflows/main.yaml:56
- This workflow specifies multi-arch platforms but doesn’t set up QEMU or Buildx—cross-platform builds may fail. Add
docker/setup-qemu-action
anddocker/setup-buildx-action
steps before the build.
platforms: linux/amd64,linux/arm64
password: ${{ secrets.GITHUB_TOKEN }} | ||
|
||
- name: Set up QEMU | ||
uses: docker/setup-qemu-action@29109295f81e9208d7d86ff1c6c12d2833863392 #v3.6.0 |
Copilot
AI
Jun 3, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] Pinning actions to full commit SHAs can hinder readability and upgrades. Consider switching to the official version tag (e.g., v3.6.0
) to make future updates clearer.
uses: docker/setup-qemu-action@29109295f81e9208d7d86ff1c6c12d2833863392 #v3.6.0 | |
uses: docker/[email protected] |
Copilot uses AI. Check for mistakes.
uses: docker/setup-qemu-action@29109295f81e9208d7d86ff1c6c12d2833863392 #v3.6.0 | ||
|
||
- name: Set up Docker Buildx | ||
uses: docker/setup-buildx-action@b5ca514318bd6ebac0fb2aedd5d36ec1b5c232a2 #v3.10.0 |
Copilot
AI
Jun 3, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] Similarly, use the version tag (e.g., v3.10.0
) instead of a raw commit SHA to improve clarity and ease version management.
uses: docker/setup-buildx-action@b5ca514318bd6ebac0fb2aedd5d36ec1b5c232a2 #v3.10.0 | |
uses: docker/[email protected] |
Copilot uses AI. Check for mistakes.
Co-authored-by: Copilot <[email protected]>
adds multi-arch builds for release images
removed provenance mode max and changes into default way (which is mode=max)