-
Notifications
You must be signed in to change notification settings - Fork 3
Chore: Remove bun #14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Great! Would you also be okay if we remove |
Could also add something like this to "engines": {
"node": "^20.0.0 || ^22.0.0",
"npm": "^8.0.0 || ^9.0.0 || ^10.0.0 || ^11.0.0"
}, |
thank you for the review. I thought i have deleted the bun.lock but seemed to miss it. |
Maybe we should go with v22 instead of v23. The even-numbered node versions usually have long-term support (LTS), which feels more stable. Odd-numbered ones feel a bit experimental to me, though that might just be my bias 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice 🎉
What this PR does / why we need it:
Right now we are using bun and npm/yarn in parallel leading to problems when adding dependencies, we have to run npm install and bun install to update all lockfiles.
Since we have no specific requirement for bun and our application is small that we not even have a performance improvement using bun, we decided to use npm/yarn based on the experience of the team.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer: