Skip to content

Conversation

enrico-kaack-comp
Copy link
Contributor

What this PR does / why we need it:
Right now we are using bun and npm/yarn in parallel leading to problems when adding dependencies, we have to run npm install and bun install to update all lockfiles.
Since we have no specific requirement for bun and our application is small that we not even have a performance improvement using bun, we decided to use npm/yarn based on the experience of the team.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

@andreaskienle
Copy link
Contributor

Great! Would you also be okay if we remove ⁠bun.lock and ⁠yarn.lock to avoid any potential confusion? What do you think?

@andreaskienle
Copy link
Contributor

Could also add something like this to package.json to document our assumptions (not sure about the versions though, just in principe):

  "engines": {
    "node": "^20.0.0 || ^22.0.0",
    "npm": "^8.0.0 || ^9.0.0 || ^10.0.0 || ^11.0.0"
  },

@enrico-kaack-comp
Copy link
Contributor Author

thank you for the review. I thought i have deleted the bun.lock but seemed to miss it.
I added the engines section with the versions I run currently and that are rather recent.

@andreaskienle
Copy link
Contributor

I added the engines section with the versions I run currently and that are rather recent.

Maybe we should go with v22 instead of v23. The even-numbered node versions usually have long-term support (LTS), which feels more stable. Odd-numbered ones feel a bit experimental to me, though that might just be my bias 😄

Copy link
Contributor

@andreaskienle andreaskienle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 🎉

@enrico-kaack-comp enrico-kaack-comp merged commit c19fb21 into main Mar 24, 2025
4 checks passed
@andreaskienle andreaskienle deleted the chore/remove-bun branch March 26, 2025 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants