Show resource errors popover for MCP #215
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucasgoral
requested review from
Hubert-Szczepanski-SAP and
andreaskienle
and removed request for
andreaskienle
There was a problem hiding this comment.
Pull Request Overview
This PR implements a resource errors popover for MCP (Managed Control Plane) resources, enhancing the user interface to display detailed error information when resource statuses are not healthy.
- Adds
messageandreasonfields to various API type definitions for better error reporting - Replaces the simple
ResourceStatusCellwith a new interactiveResourceStatusCellWithButtoncomponent that shows detailed error information in a popover - Improves type safety by removing
anytypes and adding proper TypeScript interfaces
Reviewed Changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/lib/api/types/flux/listKustomization.ts | Adds message and reason fields to condition types |
| src/lib/api/types/flux/listGitRepo.ts | Adds optional message and reason fields to condition types |
| src/lib/api/types/crossplane/listProviders.ts | Adds optional message and reason fields to condition types |
| src/lib/api/types/crossplane/listManagedResources.ts | Adds optional message and reason fields to condition types |
| src/components/Yaml/YamlViewButton.tsx | Adds debug console log statement |
| src/components/Shared/ResourceStatusCellWithButton.tsx | New component implementing popover functionality for resource status display |
| src/components/Projects/ProjectsList.tsx | Improves TypeScript types and removes eslint disable comments |
| src/components/ControlPlane/ProvidersConfig.tsx | Adjusts YAML column width |
| src/components/ControlPlane/Providers.tsx | Integrates new status cell component and adds message handling |
| src/components/ControlPlane/ManagedResources.tsx | Integrates new status cell component and adds message handling |
| src/components/ControlPlane/MCPHealthPopoverButton.tsx | Improves TypeScript types and code organization |
| src/components/ControlPlane/FluxList.tsx | Integrates new status cell component and adds message handling |
andreaskienle
requested changes
Aug 6, 2025
There was a problem hiding this comment.
Overall nice work 👍 Looking forward to seeing the users' feedback!
I noticed an issue with the new popovers. Here's how to reproduce it:
- Click on icon
A– popoverawill open (✅) - Click on icon
B– popoverawill close, popoverbwill open (✅) - Click on icon
Aagain – nothing (❌ would have expected popoverato open) - Click on icon
Aagain – popoverawill open (✅)
I think we just need to add the onClose prop to fix this.
Otherwise, everything works great from what I can see 👍
andreaskienle
approved these changes
Aug 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Show resource errors popover for MCP
Example:
