Skip to content

Conversation

andreaskienle
Copy link
Contributor

@andreaskienle andreaskienle commented Mar 25, 2025

This PR

  • installs react-error-boundary
  • removes the try/catch block in main.tsx
  • adds <Suspense> to await the fetch of the config files
  • shows a busy indicator while the loading is in transit and an error page when an error occurs.

I did not want to make too many changes at once to keep the PR small. Eventually it would probably make sense to move the authentication logic to the router and consolidate it a bit.

@andreaskienle andreaskienle marked this pull request as ready for review March 25, 2025 14:32
Copy link
Contributor

@lucasgoral lucasgoral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! :)

@andreaskienle andreaskienle merged commit e326249 into main Mar 26, 2025
4 checks passed
@andreaskienle andreaskienle deleted the rework-main-tsx branch March 26, 2025 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants