Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/Dialogs/CreateProjectDialogContainer.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ export function CreateProjectDialogContainer({

useEffect(() => {
if (username) {
setValue('members', [{ name: username, role: MemberRoles.admin, kind: 'User' }]);
setValue('members', [{ name: username, roles: [MemberRoles.admin], kind: 'User' }]);
}
if (!isOpen) {
clearForm();
Expand Down
2 changes: 1 addition & 1 deletion src/components/Dialogs/CreateWorkspaceDialogContainer.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ export function CreateWorkspaceDialogContainer({

useEffect(() => {
if (username) {
setValue('members', [{ name: username, role: MemberRoles.admin, kind: 'User' }]);
setValue('members', [{ name: username, roles: [MemberRoles.admin], kind: 'User' }]);
}
if (!isOpen) {
clearForm();
Expand Down
4 changes: 2 additions & 2 deletions src/components/Members/AddEditMemberDialog.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ export const AddEditMemberDialog: FC<AddEditMemberDialogProps> = ({
if (memberToEdit) {
reset({
name: memberToEdit.name,
role: memberToEdit.role || MemberRoles.view,
role: memberToEdit.roles?.[0] || MemberRoles.view,
accountType: memberToEdit.kind === 'User' ? 'User' : 'ServiceAccount',
namespace: memberToEdit?.namespace || '',
});
Expand All @@ -111,7 +111,7 @@ export const AddEditMemberDialog: FC<AddEditMemberDialogProps> = ({

const newMember: Member = {
name: trimmedName,
role: data.role,
roles: [data.role],
kind: data.accountType,
...(data.accountType === 'ServiceAccount' && data.namespace && { namespace: data.namespace }),
};
Expand Down
3 changes: 1 addition & 2 deletions src/components/Members/MemberTable.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -111,11 +111,10 @@ export const MemberTable: FC<MemberTableProps> = ({
</Infobox>
);
}

const data: MemberTableRow[] = members.map((m) => {
return {
email: m.name,
role: MemberRolesDetailed[m.role as MemberRoles]?.displayValue,
role: MemberRolesDetailed[m.roles?.[0] as MemberRoles]?.displayValue ?? m.roles?.toString(),
kind: m.kind,
namespace: m.namespace ?? '',
_member: m,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ export const CreateManagedControlPlaneWizardContainer: FC<CreateManagedControlPl

useEffect(() => {
if (user?.email && isOpen) {
setValue('members', [{ name: user.email, role: MemberRoles.admin, kind: 'User' }]);
setValue('members', [{ name: user.email, roles: [MemberRoles.admin], kind: 'User' }]);
}
if (!isOpen) {
clearFormFields();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ export const SummarizeStep: React.FC<SummarizeStepProps> = ({ watch, projectName
<br />
<List headerText={t('common.members')}>
{watch('members').map((member) => (
<ListItemStandard key={member.name} text={member.name} additionalText={member.role} />
<ListItemStandard key={member.name} text={member.name} additionalText={member.roles?.[0]} />
))}
</List>
<br />
Expand Down
2 changes: 1 addition & 1 deletion src/lib/api/types/crate/createManagedControlPlane.ts
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ export const CreateManagedControlPlane = (
authorization: {
roleBindings:
optional?.members?.map((member) => ({
role: member.role,
role: member.roles?.[0],
subjects: [
{
kind: member.kind as AccountType,
Expand Down
4 changes: 2 additions & 2 deletions src/lib/api/types/crate/createProject.ts
Original file line number Diff line number Diff line change
Expand Up @@ -45,10 +45,10 @@ export const CreateProject = (
},
spec: {
members:
optional?.members?.map(({ kind, namespace, role, name }) => ({
optional?.members?.map(({ kind, namespace, roles, name }) => ({
kind,
name,
roles: [role],
roles,
namespace: kind === 'ServiceAccount' ? (namespace ?? 'default') : undefined,
})) ?? [],
},
Expand Down
4 changes: 2 additions & 2 deletions src/lib/api/types/crate/createWorkspace.ts
Original file line number Diff line number Diff line change
Expand Up @@ -48,10 +48,10 @@ export const CreateWorkspace = (
},
spec: {
members:
optional?.members?.map(({ kind, namespace, role, name }) => ({
optional?.members?.map(({ kind, namespace, roles, name }) => ({
kind,
name,
roles: [role],
roles,
namespace: kind === 'ServiceAccount' ? (namespace ?? 'default') : undefined,
})) ?? [],
},
Expand Down
2 changes: 1 addition & 1 deletion src/lib/api/types/crate/listWorkspaces.ts
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,6 @@ export function isWorkspaceReady(workspace: ListWorkspacesType): boolean {
export const ListWorkspaces = (projectName?: string): Resource<ListWorkspacesType[]> => {
return {
path: `/apis/core.openmcp.cloud/v1alpha1/namespaces/project-${projectName}/workspaces`,
jq: '[.items[] | {metadata: .metadata | {name, namespace, annotations, deletionTimestamp}, status: .status, spec: .spec | {members: [.members[] | {name, roles}]}}]',
jq: '[.items[] | {metadata: .metadata | {name, namespace, annotations, deletionTimestamp}, status: .status, spec: .spec | {members: [.members[] | {name, roles, kind, namespace}]}}]',
};
};
2 changes: 1 addition & 1 deletion src/lib/api/types/shared/members.ts
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ export enum MemberKind {
export interface Member {
kind: string;
name: string;
role: string;
roles: string[];
namespace?: string;
}

Expand Down
Loading