Skip to content

[To discuss] Move inline styles to CSS module #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 4, 2025
Merged

[To discuss] Move inline styles to CSS module #26

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
3940f98
Move inline styles to CSS module
andreaskienle Mar 25, 2025
8a4e1d3
Merge branch 'main' into spike/css-modules
andreaskienle Apr 2, 2025
af6d356
Merge branch 'main' into spike/css-modules
andreaskienle Apr 3, 2025
de0415d
Refactor
andreaskienle Apr 3, 2025
abca916
Move from px to rem
andreaskienle Apr 3, 2025
b80e91f
Merge branch 'main' into spike/css-modules
lucasgoral Apr 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions src/components/ControlPlanes/ControlPlaneCard/ControlPlaneCard.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
.card {
margin: 0.75rem 0.75rem 0.75rem 0;
}

.container {
padding: 1.25rem;
}

.row {
padding-top: 1.25rem;
}
26 changes: 12 additions & 14 deletions ...onents/ControlPlanes/ControlPlaneCard.tsx → ...nes/ControlPlaneCard/ControlPlaneCard.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,25 +2,26 @@ import { Button, Card, FlexBox, Label, Title } from '@ui5/webcomponents-react';
import '@ui5/webcomponents-fiori/dist/illustrations/NoData.js';
import '@ui5/webcomponents-fiori/dist/illustrations/EmptyList.js';
import '@ui5/webcomponents-icons/dist/delete';
import ConnectButton from './ConnectButton.tsx';
import { ListWorkspacesType } from '../../lib/api/types/crate/listWorkspaces.ts';
import ConnectButton from '../ConnectButton.tsx';
import { ListWorkspacesType } from '../../../lib/api/types/crate/listWorkspaces.ts';
import {
ListControlPlanesType,
ReadyStatus,
} from '../../lib/api/types/crate/controlPlanes.ts';
} from '../../../lib/api/types/crate/controlPlanes.ts';
import TitleLevel from '@ui5/webcomponents/dist/types/TitleLevel.js';
import ButtonDesign from '@ui5/webcomponents/dist/types/ButtonDesign.js';
import { useState } from 'react';
import { useApiResourceMutation } from '../../lib/api/useApiResource.ts';
import { useApiResourceMutation } from '../../../lib/api/useApiResource.ts';
import {
DeleteMCPResource,
DeleteMCPType,
PatchMCPResourceForDeletion,
PatchMCPResourceForDeletionBody,
} from '../../lib/api/types/crate/deleteMCP.ts';
import { DeleteConfirmationDialog } from '../Dialogs/DeleteConfirmationDialog.tsx';
import MCPHealthPopoverButton from '../ControlPlane/MCPHealthPopoverButton.tsx';
import { KubectlDeleteMcp } from '../Dialogs/KubectlCommandInfo/Controllers/KubectlDeleteMcp.tsx';
} from '../../../lib/api/types/crate/deleteMCP.ts';
import { DeleteConfirmationDialog } from '../../Dialogs/DeleteConfirmationDialog.tsx';
import MCPHealthPopoverButton from '../../ControlPlane/MCPHealthPopoverButton.tsx';
import styles from './ControlPlaneCard.module.css';
import { KubectlDeleteMcp } from '../../Dialogs/KubectlCommandInfo/Controllers/KubectlDeleteMcp.tsx';

interface Props {
controlPlane: ListControlPlanesType;
Expand Down Expand Up @@ -53,11 +54,8 @@ export function ControlPlaneCard({

return (
<>
<Card
key={`${name}--${namespace}`}
style={{ margin: '12px 12px 12px 0' }}
>
<div style={{ padding: '20px' }}>
<Card key={`${name}--${namespace}`} className={styles.card}>
<div className={styles.container}>
<FlexBox direction="Column">
<FlexBox direction="Row" justifyContent="SpaceBetween">
<FlexBox direction="Column">
Expand All @@ -81,7 +79,7 @@ export function ControlPlaneCard({
direction="Row"
justifyContent="SpaceBetween"
alignItems="Center"
style={{ paddingTop: '20px' }}
className={styles.row}
>
<MCPHealthPopoverButton mcpStatus={controlPlane.status} />
<ConnectButton
Expand Down
2 changes: 1 addition & 1 deletion src/components/ControlPlanes/List/ControlPlaneListWorkspaceGridTile.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import '@ui5/webcomponents-icons/dist/delete';
import ButtonDesign from '@ui5/webcomponents/dist/types/ButtonDesign.js';
import { CopyButton } from '../../Shared/CopyButton.tsx';
import { NoManagedControlPlaneBanner } from '../NoManagedControlPlaneBanner.tsx';
import { ControlPlaneCard } from '../ControlPlaneCard.tsx';
import { ControlPlaneCard } from '../ControlPlaneCard/ControlPlaneCard.tsx';
import {
ListWorkspacesType,
isWorkspaceReady,
Expand Down
Loading