generated from openmcp-project/repository-template
-
Notifications
You must be signed in to change notification settings - Fork 3
Feat/mcp templates #278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Feat/mcp templates #278
Changes from 8 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
37793d8
Templates loaded from file onboardingAPI TBD
Hubert-Szczepanski-SAP 3e601de
removing example template
Hubert-Szczepanski-SAP c59c494
Merge branch 'main' into feat/mcp-templates
Hubert-Szczepanski-SAP 49ce9b9
linter auto fixes
Hubert-Szczepanski-SAP fd97f90
fixing linter issues
Hubert-Szczepanski-SAP 28965e1
fixing linter
Hubert-Szczepanski-SAP 207ceac
Fixing spelling
Hubert-Szczepanski-SAP 7c113f7
Merge branch 'main' into feat/mcp-templates
Hubert-Szczepanski-SAP ac877b9
PR requested changes
Hubert-Szczepanski-SAP 993de40
Merge branch 'feat/mcp-templates' of https://github.com/openmcp-proje…
Hubert-Szczepanski-SAP 455bbd5
Merge branch 'main' into feat/mcp-templates
Hubert-Szczepanski-SAP b6e6cfd
PR comments
Hubert-Szczepanski-SAP a8d4889
Merge branch 'feat/mcp-templates' of https://github.com/openmcp-proje…
Hubert-Szczepanski-SAP a3b8823
Removing unnecessary useEffect
Hubert-Szczepanski-SAP File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you check if this useEffect is necessary? Also the one below?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
with the first one is generating a lot of error in console, without the second one it doesn't work
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe you can at least add comments describing what code inside these useEffects do to make it easier to understand
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok I think I misunderstood this request from @andreaskienle . I simplified it, merged it to one useEffect. The last useEffect was needed when we have template step at the beginning, but in this scenario it's not actually needed.