-
Notifications
You must be signed in to change notification settings - Fork 3
feature: Edit ManagedControlPlane using the wizard #287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR implements a comprehensive edit feature for ManagedControlPlane resources, allowing users to modify existing control planes through the same wizard interface used for creation. The implementation includes support for displaying differences between original and modified configurations, proper form initialization with existing data, and handling of the edit workflow across multiple components.
- Adds wizard-based editing functionality for ManagedControlPlane resources
- Implements YAML diff visualization to show changes during editing
- Extends existing wizard components to support both create and edit modes
Reviewed Changes
Copilot reviewed 23 out of 24 changed files in this pull request and generated 3 comments.
Show a summary per file
File | Description |
---|---|
src/views/login.css | Adds CSS styling for description text alignment |
src/views/Login.tsx | Updates login page styling and replaces HTML anchor with UI5 Link component |
src/spaces/mcp/pages/McpPage.tsx | Integrates edit wizard functionality and menu into the MCP page |
src/lib/api/useApiResource.ts | Adds excludeMcpConfig parameter to mutation hook for conditional API configuration |
src/lib/api/types/shared/keyNames.ts | Adds new label constants for project and workspace identification |
src/lib/api/types/mcpResource.ts | Creates comprehensive TypeScript interfaces for ManagedControlPlane resources |
src/lib/api/types/crate/listManagedComponents.ts | Refactors and exports interfaces with optional properties |
src/lib/api/types/crate/createManagedControlPlane.ts | Adds update resource endpoint for PATCH operations |
src/lib/api/types/crate/controlPlanes.ts | Updates JQ queries to include annotations for display names |
src/components/Yaml/YamlDiff.tsx | Implements new YAML diff visualization component |
src/components/Wizards/CreateManagedControlPlane/SummarizeStep.tsx | Adds diff mode support to the summary step |
src/components/Wizards/CreateManagedControlPlane/EditManagedControlPlaneWizardDataLoader.tsx | Creates data loader component for edit wizard initialization |
src/components/Wizards/CreateManagedControlPlane/CreateManagedControlPlaneWizardContainer.tsx | Extends wizard container to support edit mode with form pre-population |
src/components/Dialogs/MetadataForm.tsx | Adds edit mode support with disabled name field |
src/components/ControlPlanes/List/ControlPlaneListWorkspaceGridTile.tsx | Updates wizard initialization for create mode |
src/components/ControlPlanes/ControlPlanePageMenu.tsx | Creates overflow menu for MCP page actions |
src/components/ControlPlanes/ControlPlaneCard/ControlPlaneCardMenu.tsx | Creates card-level menu with edit and delete options |
src/components/ControlPlanes/ControlPlaneCard/ControlPlaneCard.tsx | Integrates edit functionality and display name support |
src/components/ComponentsSelection/ComponentsSelectionContainer.tsx | Enhances component selection with edit mode support and initial selections |
public/locales/en.json | Adds localization strings for edit functionality |
package.json | Adds diff library dependency |
Comments suppressed due to low confidence (1)
src/components/Wizards/CreateManagedControlPlane/CreateManagedControlPlaneWizardContainer.tsx:1
- The else block was removed but these setValue calls for clearing charging fields when no template is selected are still necessary to reset the form properly.
import { FC, useCallback, useEffect, useMemo, useRef, useState } from 'react';
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
src/components/Wizards/CreateManagedControlPlane/CreateManagedControlPlaneWizardContainer.tsx
Outdated
Show resolved
Hide resolved
src/components/Wizards/CreateManagedControlPlane/CreateManagedControlPlaneWizardContainer.tsx
Outdated
Show resolved
Hide resolved
src/components/ComponentsSelection/ComponentsSelectionContainer.tsx
Outdated
Show resolved
Hide resolved
…ControlPlaneWizardContainer.tsx Co-authored-by: Copilot <[email protected]>
…ControlPlaneWizardContainer.tsx Co-authored-by: Copilot <[email protected]>
…r.tsx Co-authored-by: Copilot <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job!
What this PR does / why we need it:
This PR adds feature that allows users EDIT ManagedControlPlane using the wizard