Skip to content

Conversation

lucasgoral
Copy link
Contributor

@lucasgoral lucasgoral commented Sep 15, 2025

What this PR does / why we need it:

This PR adds feature that allows users EDIT ManagedControlPlane using the wizard

@lucasgoral lucasgoral changed the title Edit mcp feature: Edit ManagedControlPlane using the wizard Sep 19, 2025
@lucasgoral lucasgoral marked this pull request as ready for review September 19, 2025 07:47
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements a comprehensive edit feature for ManagedControlPlane resources, allowing users to modify existing control planes through the same wizard interface used for creation. The implementation includes support for displaying differences between original and modified configurations, proper form initialization with existing data, and handling of the edit workflow across multiple components.

  • Adds wizard-based editing functionality for ManagedControlPlane resources
  • Implements YAML diff visualization to show changes during editing
  • Extends existing wizard components to support both create and edit modes

Reviewed Changes

Copilot reviewed 23 out of 24 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
src/views/login.css Adds CSS styling for description text alignment
src/views/Login.tsx Updates login page styling and replaces HTML anchor with UI5 Link component
src/spaces/mcp/pages/McpPage.tsx Integrates edit wizard functionality and menu into the MCP page
src/lib/api/useApiResource.ts Adds excludeMcpConfig parameter to mutation hook for conditional API configuration
src/lib/api/types/shared/keyNames.ts Adds new label constants for project and workspace identification
src/lib/api/types/mcpResource.ts Creates comprehensive TypeScript interfaces for ManagedControlPlane resources
src/lib/api/types/crate/listManagedComponents.ts Refactors and exports interfaces with optional properties
src/lib/api/types/crate/createManagedControlPlane.ts Adds update resource endpoint for PATCH operations
src/lib/api/types/crate/controlPlanes.ts Updates JQ queries to include annotations for display names
src/components/Yaml/YamlDiff.tsx Implements new YAML diff visualization component
src/components/Wizards/CreateManagedControlPlane/SummarizeStep.tsx Adds diff mode support to the summary step
src/components/Wizards/CreateManagedControlPlane/EditManagedControlPlaneWizardDataLoader.tsx Creates data loader component for edit wizard initialization
src/components/Wizards/CreateManagedControlPlane/CreateManagedControlPlaneWizardContainer.tsx Extends wizard container to support edit mode with form pre-population
src/components/Dialogs/MetadataForm.tsx Adds edit mode support with disabled name field
src/components/ControlPlanes/List/ControlPlaneListWorkspaceGridTile.tsx Updates wizard initialization for create mode
src/components/ControlPlanes/ControlPlanePageMenu.tsx Creates overflow menu for MCP page actions
src/components/ControlPlanes/ControlPlaneCard/ControlPlaneCardMenu.tsx Creates card-level menu with edit and delete options
src/components/ControlPlanes/ControlPlaneCard/ControlPlaneCard.tsx Integrates edit functionality and display name support
src/components/ComponentsSelection/ComponentsSelectionContainer.tsx Enhances component selection with edit mode support and initial selections
public/locales/en.json Adds localization strings for edit functionality
package.json Adds diff library dependency
Comments suppressed due to low confidence (1)

src/components/Wizards/CreateManagedControlPlane/CreateManagedControlPlaneWizardContainer.tsx:1

  • The else block was removed but these setValue calls for clearing charging fields when no template is selected are still necessary to reset the form properly.
import { FC, useCallback, useEffect, useMemo, useRef, useState } from 'react';

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Contributor

@Hubert-Szczepanski-SAP Hubert-Szczepanski-SAP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

@lucasgoral lucasgoral merged commit 03ec511 into main Sep 23, 2025
5 checks passed
@lucasgoral lucasgoral deleted the edit-mcp branch September 23, 2025 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants