-
Notifications
You must be signed in to change notification settings - Fork 3
feat: change favicon #294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: change favicon #294
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR implements a comprehensive favicon and branding update, transitioning from a generic "MCP" brand to "ManagedControlPlane UI" with proper SAP branding and favicon assets.
- Updates application title and branding throughout the UI components
- Implements comprehensive favicon support with multiple formats and sizes
- Removes unused frontend configuration logic for dynamic title setting
Reviewed Changes
Copilot reviewed 5 out of 14 changed files in this pull request and generated 1 comment.
Show a summary per file
File | Description |
---|---|
src/components/Core/ShellBar.tsx | Updates logo source to SAP logo and makes application name translatable |
src/App.tsx | Removes dynamic title setting logic that's no longer needed |
public/locales/en.json | Adds translation key for the new application name |
public/favicon/site.webmanifest | Adds web app manifest for PWA support |
index.html | Updates favicon links and page title to new branding |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job, just wonder if we want to have SAP favicon or some custom icon for our app?
@GenosseOtt changed the icon. I guess we don’t have an icon for our app for now, so we’ll stick to SAP branding, right? |
Unfortunately we dont have one yet. @lucasgoral/ @andreaskienle I am still imagining the wand or the bow tie of the orchestrator icon to be used as a fav icon - but I always fail when creating it (people dont recognize it without context). if you have ideas please go wild in figma... haha |
Implements openmcp-project/backlog#288
This PR changes the favion and the shellbar logo. It also renames our app to ManagedControlPlane UI (for now).