Skip to content

Conversation

andreaskienle
Copy link
Contributor

@andreaskienle andreaskienle commented Sep 24, 2025

Implements openmcp-project/backlog#288

This PR changes the favion and the shellbar logo. It also renames our app to ManagedControlPlane UI (for now).

image

@Copilot Copilot AI review requested due to automatic review settings September 24, 2025 14:21
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements a comprehensive favicon and branding update, transitioning from a generic "MCP" brand to "ManagedControlPlane UI" with proper SAP branding and favicon assets.

  • Updates application title and branding throughout the UI components
  • Implements comprehensive favicon support with multiple formats and sizes
  • Removes unused frontend configuration logic for dynamic title setting

Reviewed Changes

Copilot reviewed 5 out of 14 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/components/Core/ShellBar.tsx Updates logo source to SAP logo and makes application name translatable
src/App.tsx Removes dynamic title setting logic that's no longer needed
public/locales/en.json Adds translation key for the new application name
public/favicon/site.webmanifest Adds web app manifest for PWA support
index.html Updates favicon links and page title to new branding

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

lucasgoral
lucasgoral previously approved these changes Sep 26, 2025
Copy link
Contributor

@lucasgoral lucasgoral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, just wonder if we want to have SAP favicon or some custom icon for our app?

@andreaskienle
Copy link
Contributor Author

andreaskienle commented Sep 26, 2025

Good job, just wonder if we want to have SAP favicon or some custom icon for our app?

@GenosseOtt changed the icon. I guess we don’t have an icon for our app for now, so we’ll stick to SAP branding, right?

@GenosseOtt
Copy link
Contributor

Unfortunately we dont have one yet. @lucasgoral/ @andreaskienle I am still imagining the wand or the bow tie of the orchestrator icon to be used as a fav icon - but I always fail when creating it (people dont recognize it without context). if you have ideas please go wild in figma... haha

@andreaskienle andreaskienle merged commit 21bd296 into main Oct 7, 2025
5 checks passed
@andreaskienle andreaskienle deleted the favicon branch October 7, 2025 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants