Skip to content

Conversation

lucasgoral
Copy link
Contributor

@lucasgoral lucasgoral commented Oct 1, 2025

What this PR does / why we need it:
This PR replaces the existing react-syntax-highlighter component with Monaco Editor for displaying and editing YAML files. The change provides a more feature-rich code editing experience with syntax validation, highlighting etc.

@lucasgoral lucasgoral changed the title Resources yaml edit Changed component to display YAML files to Monaco Editor Oct 1, 2025
@lucasgoral lucasgoral requested a review from Copilot October 1, 2025 11:23
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR replaces the existing react-syntax-highlighter component with Monaco Editor for displaying and editing YAML files. The change provides a more feature-rich code editing experience with syntax highlighting, themes, and diff visualization capabilities.

  • Integrates Monaco Editor with YAML language support and custom GitHub themes
  • Creates reusable YamlEditor and YamlDiffEditor wrapper components
  • Updates all YAML viewing components to use Monaco Editor instead of syntax highlighter

Reviewed Changes

Copilot reviewed 16 out of 17 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
vite.config.js Adds vite-plugin-static-copy to bundle Monaco Editor assets
src/main.tsx Initializes Monaco Editor configuration on app startup
src/lib/monaco.ts Configures Monaco Editor with YAML support and GitHub themes
src/components/YamlEditor/*.tsx New wrapper components for Monaco Editor and DiffEditor
src/components/Yaml/YamlViewer.tsx Replaces syntax highlighter with Monaco Editor
src/components/Yaml/YamlDiff.tsx Replaces custom diff implementation with Monaco DiffEditor
package.json Updates dependencies to include Monaco Editor packages

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@lucasgoral lucasgoral requested a review from Copilot October 2, 2025 12:39
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 20 out of 22 changed files in this pull request and generated 2 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@lucasgoral lucasgoral marked this pull request as ready for review October 3, 2025 07:29
Copy link
Contributor

@Hubert-Szczepanski-SAP Hubert-Szczepanski-SAP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!! (Reviewed via call)

@lucasgoral lucasgoral merged commit 4af57b5 into main Oct 3, 2025
5 checks passed
@lucasgoral lucasgoral deleted the resources-yaml-edit branch October 3, 2025 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants