Skip to content

feat: fix percentage bar showing 100 even though it should be 0 #316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 7, 2025
Merged

feat: fix percentage bar showing 100 even though it should be 0 #316

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a645205
feat: fix percentage bar showing 100 even though it should be 0
Lasserich Oct 2, 2025
89571e0
Revert changes to package-lock.json
andreaskienle Oct 7, 2025
e9cb412
Merge branch 'main' into fix/hints
andreaskienle Oct 7, 2025
915dd1d
Merge branch 'main' into fix/hints
andreaskienle Oct 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 14 additions & 3 deletions src/components/HintsCardsRow/MultiPercentageBar/MultiPercentageBar.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,15 +51,26 @@
.labelGroup {
display: flex;
align-items: center;
gap: 6px;
gap: 8px;
justify-content: space-between;
width: 100%;
}

.label,
.percentage {
font-size: var(--label-font-size);
font-weight: 400;
font-weight: 600;
color: var(--sapTextColor, #374151);
transition: color 0.3s ease, font-weight 0.3s ease;
text-align: right;
white-space: nowrap;
}

.label {
font-size: var(--label-font-size);
font-weight: 400;
color: var(--sapTextColor, #6b7280);
transition: color 0.3s ease, font-weight 0.3s ease;
flex: 1;
}

.label.healthy,
Expand Down
18 changes: 13 additions & 5 deletions src/components/HintsCardsRow/MultiPercentageBar/MultiPercentageBar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,17 +44,25 @@ export const MultiPercentageBar: React.FC<MultiPercentageBarProps> = ({
style,
animationDuration = 400, // Match CSS default
}) => {
// Memoize filtered segments
// Memoize filtered segments for rendering only
const filteredSegments = useMemo(() => {
return showOnlyNonZero ? segments.filter((segment) => segment.percentage > 0) : segments;
if (showOnlyNonZero) {
const nonZeroSegments = segments.filter((segment) => segment.percentage > 0);
if (nonZeroSegments.length === 0 && segments.length > 0) {
return segments;
}
return nonZeroSegments;
}
return segments;
}, [segments, showOnlyNonZero]);

if (filteredSegments.length === 0) {
return null;
}

const primaryPercentage = filteredSegments[0]?.percentage || 0;
const displayLabel = label || 'Healthy';
const primarySegment = segments[0];
const primaryPercentage = primarySegment?.percentage || 0;
const displayLabel = label || primarySegment?.label || 'Healthy';
const allHealthy = isHealthy !== undefined ? isHealthy : primaryPercentage === 100;

return (
Expand All @@ -78,10 +86,10 @@ export const MultiPercentageBar: React.FC<MultiPercentageBarProps> = ({
{showLabels && (
<div className={styles.labelContainer}>
<div className={styles.labelGroup}>
<span className={`${styles.label} ${allHealthy ? styles.healthy : ''}`}>{displayLabel}</span>
{showPercentage && (
<span className={`${styles.percentage} ${allHealthy ? styles.healthy : ''}`}>{primaryPercentage}%</span>
)}
<span className={`${styles.label} ${allHealthy ? styles.healthy : ''}`}>{displayLabel}</span>
</div>
</div>
)}
Expand Down
Loading