Skip to content

fix: MCP header text in dark mode #320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 7, 2025
Merged

fix: MCP header text in dark mode #320

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b990c10
fix: MCP header text in dark mode
andreaskienle Oct 7, 2025
5316832
fix: cypress tests
andreaskienle Oct 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/spaces/mcp/components/McpHeader.cy.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,9 @@ describe('McpHeader', () => {

cy.mount(<McpHeader mcp={mcp} />);

cy.contains('span', 'my-control-plane').should('be.visible');
cy.contains('span', '[email protected]').should('be.visible');
cy.contains('span', `${creationDateAsString} (2 days ago)`).should('be.visible');
cy.contains('my-control-plane').should('be.visible');
cy.contains('[email protected]').should('be.visible');
cy.contains(`${creationDateAsString} (2 days ago)`).should('be.visible');
});

it('renders with missing MCP metadata', () => {
Expand All @@ -44,7 +44,7 @@ describe('McpHeader', () => {

cy.mount(<McpHeader mcp={mcp} />);

cy.contains('span', 'my-control-plane').should('be.visible');
cy.contains('span', `${creationDateAsString} (2 days ago)`).should('be.visible');
cy.contains('my-control-plane').should('be.visible');
cy.contains(`${creationDateAsString} (2 days ago)`).should('be.visible');
});
});
9 changes: 5 additions & 4 deletions src/spaces/mcp/components/McpHeader.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import { ControlPlaneType } from '../../../lib/api/types/crate/controlPlanes.ts';
import { Text } from '@ui5/webcomponents-react';

import styles from './McpHeader.module.css';
import { formatDateAsTimeAgo } from '../../../utils/i18n/timeAgo.ts';
Expand All @@ -23,17 +24,17 @@ export function McpHeader({ mcp }: McpHeaderProps) {
<div className={styles.container}>
<div className={styles.grid}>
<span className={styles.label}>{t('McpHeader.nameLabel')}</span>
<span>{mcp.metadata.name}</span>
<Text>{mcp.metadata.name}</Text>

<span className={styles.label}>{t('McpHeader.createdOnLabel')}</span>
<span>
<Text>
{created} ({formatDateAsTimeAgo(mcp.metadata.creationTimestamp)})
</span>
</Text>

{createdBy ? (
<>
<span className={styles.label}>{t('McpHeader.createdByLabel')}</span>
<span>{createdBy}</span>
<Text>{createdBy}</Text>
</>
) : null}
</div>
Expand Down
Loading