Edit YAMLs of MCP resources #323
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR implements YAML editing functionality for MCP (Managed Control Plane) resources, enabling users to edit Kubernetes resource configurations directly through a YAML editor interface.
Key changes include:
- Enhanced YamlEditor component with edit mode, validation, and apply functionality
- New utility function to convert Kubernetes resources to clean configuration format
- Integration of YAML editing capabilities into resource management components
- Added edit actions to resource tables with confirmation workflows
Reviewed Changes
Copilot reviewed 20 out of 20 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/utils/convertToResourceConfig.ts | New utility to convert Kubernetes resources to clean manifest format by removing server-managed fields |
| src/utils/convertToResourceConfig.spec.ts | Comprehensive test coverage for the resource conversion utility |
| src/lib/api/types/crossplane/handleResourcePatch.ts | New API handler for patching Kubernetes resources via server API |
| src/lib/api/types/crate/createManagedControlPlane.ts | Refactored component naming and variable names for better clarity |
| src/components/YamlEditor/YamlEditor.tsx | Enhanced YAML editor with edit mode, validation, and apply functionality |
| src/components/YamlEditor/YamlDiffEditor.tsx | Updated diff editor options and variable naming |
| src/components/Yaml/*.tsx | Updated YAML viewing components to support edit mode and patch workflows |
| src/components/ControlPlane/*.tsx | Added edit actions and YAML editing integration to resource management tables |
| public/locales/en.json | Added translations for new edit functionality and error messages |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Feature to allow users edit resources inside MCP by editing YAML config files.