Skip to content

Conversation

andreaskienle
Copy link
Contributor

@andreaskienle andreaskienle commented Mar 18, 2025

After #3 this PR applies all automatically fixable rules.

It’s the result after eslint ./src --report-unused-disable-directives --max-warnings 0 --fix

@enrico-kaack-comp
Copy link
Contributor

enrico-kaack-comp commented Mar 18, 2025

may you also add a gh action workflow that checks for violations and fails on warnings/errors? we can than include this in the PR test to enforce this rules

@andreaskienle
Copy link
Contributor Author

may you also add a gh action workflow that checks for violations and fails on warnings/errors? we can than include this in the PR test to enforce this rules

Eventually, we can do this, I think it’s a good idea, but at the moment, we have too many errors. The pull request only fixes those for which there is an automatic solution. What's left are still 33 files with errors, especially about ⁠any in TypeScript, as well as other issues that we should investigate a bit.

My hope is that we can resolve these issues when we modify the files, for example, during the migration to the new backend.

Perhaps we could set a reminder to revisit this topic in a few weeks or months. Additionally, we could run the linter in a GitHub action in warning mode only.

@andreaskienle
Copy link
Contributor Author

Here’s the follow-up task we talked about: https://github.tools.sap/kubernetes/k8s-lifecycle-management/issues/2142. I hope it's okay that I linked it here.

@andreaskienle andreaskienle merged commit 31c2d39 into main Mar 20, 2025
4 checks passed
@andreaskienle andreaskienle deleted the apply-linter branch March 20, 2025 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants