Skip to content

Conversation

Hubert-Szczepanski-SAP
Copy link
Contributor

What this PR does / why we need it:
This PR is to make proper Providers table. Adjusting to current approach created by @andreaskienle

Which issue(s) this PR fixes:
image

Special notes for your reviewer:

@andreaskienle andreaskienle self-requested a review March 19, 2025 10:21
Copy link
Contributor

@andreaskienle andreaskienle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on this! I have a few minor suggestions for refactoring, but overall it looks very good 🙌🏻

base before rebase
Adjusting to resources approach + adding transition time
regex fix
review changes
@Hubert-Szczepanski-SAP Hubert-Szczepanski-SAP force-pushed the origin/feature/new-providers-table branch from 215f68a to 3e24e72 Compare March 20, 2025 14:00
Copy link
Contributor

@andreaskienle andreaskienle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@Hubert-Szczepanski-SAP Hubert-Szczepanski-SAP merged commit fcaf193 into main Mar 20, 2025
4 checks passed
@Hubert-Szczepanski-SAP Hubert-Szczepanski-SAP deleted the origin/feature/new-providers-table branch March 26, 2025 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants