-
Notifications
You must be signed in to change notification settings - Fork 3
Feat: Support button for MCP github issues with info dump #62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Support button for MCP github issues with info dump #62
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job, Fabian! It's awesome to see the new issue fields prefilled. 🎉
Just a couple of minor notes, especially for the GitHub URL, let's make sure to add it to frontend-config.json since it's distinct from the documentation URL (as noted below).
what would be the best approach for parameters for linkcreator constructor? I was going to make githubBaseUrl ?: (optional) But is there a better way? Image adding 10 different url's what then. (I pushed anyway with error just so you can take a look). githubBaseUrl = https://github.tools.sap/openmcp (could be better name, also not sure?) Thank you @andreaskienle @enrico-kaack-comp |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! ✨
There are two unused text entries we can remove, and then it’s ready to be merged. 🎉
As a follow-up, it would be good to gracefully handle cases where the link configuration is missing — for example, by hiding the button when no link is available. But that’s something we can tackle in a separate task (there’s already a backlog item). For now, everything looks good!
Co-authored-by: Andreas Kienle <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏻
Please review if url construction logic could be better implemented. Is link manager used with best practise?
https://github.tools.sap/kubernetes/k8s-lifecycle-management/issues/2049